Skip to content

Commit

Permalink
iotests: Test help option for unsupporting formats
Browse files Browse the repository at this point in the history
This adds test cases to 082 for qemu-img create/convert/amend "-o help"
on formats that do not support creation or amendment, respectively.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20180509210023.20283-7-mreitz@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
  • Loading branch information
XanClic committed Jun 11, 2018
1 parent d402b6a commit e53995e
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tests/qemu-iotests/082
Expand Up @@ -97,6 +97,9 @@ run_qemu_img create -f $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST_
run_qemu_img create -f $IMGFMT -o help
run_qemu_img create -o help

# Try help option for a format that does not support creation
run_qemu_img create -f bochs -o help

echo
echo === convert: Options specified more than once ===

Expand Down Expand Up @@ -151,6 +154,9 @@ run_qemu_img convert -O $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST
run_qemu_img convert -O $IMGFMT -o help
run_qemu_img convert -o help

# Try help option for a format that does not support creation
run_qemu_img convert -O bochs -o help

echo
echo === amend: Options specified more than once ===

Expand Down Expand Up @@ -201,6 +207,9 @@ run_qemu_img amend -f $IMGFMT -o backing_file="$TEST_IMG" -o ,, -o help "$TEST_I
run_qemu_img amend -f $IMGFMT -o help
run_qemu_img convert -o help

# Try help option for a format that does not support amendment
run_qemu_img amend -f bochs -o help

# success, all done
echo "*** done"
rm -f $seq.full
Expand Down
9 changes: 9 additions & 0 deletions tests/qemu-iotests/082.out
Expand Up @@ -249,6 +249,9 @@ Testing: create -o help
Supported options:
size Virtual disk size

Testing: create -f bochs -o help
qemu-img: Format driver 'bochs' does not support image creation

=== convert: Options specified more than once ===

Testing: create -f qcow2 TEST_DIR/t.qcow2 128M
Expand Down Expand Up @@ -502,6 +505,9 @@ Testing: convert -o help
Supported options:
size Virtual disk size

Testing: convert -O bochs -o help
qemu-img: Format driver 'bochs' does not support image creation

=== amend: Options specified more than once ===

Testing: amend -f foo -f qcow2 -o lazy_refcounts=on TEST_DIR/t.qcow2
Expand Down Expand Up @@ -763,4 +769,7 @@ Note that not all of these options may be amendable.
Testing: convert -o help
Supported options:
size Virtual disk size

Testing: amend -f bochs -o help
qemu-img: Format driver 'bochs' does not support option amendment
*** done

0 comments on commit e53995e

Please sign in to comment.