Skip to content

Commit

Permalink
rtl8139: use inline net_crc32() and bitshift instead of compute_mcast…
Browse files Browse the repository at this point in the history
…_idx()

This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
mcayland authored and jasowang committed Dec 22, 2017
1 parent 084e2b1 commit e7a58fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/net/rtl8139.c
Expand Up @@ -882,7 +882,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const uint8_t *buf, size_t
return size;
}

int mcast_idx = compute_mcast_idx(buf);
int mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;

if (!(s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))))
{
Expand Down

0 comments on commit e7a58fc

Please sign in to comment.