Skip to content

Commit

Permalink
tests/tcg: Remove run-test-mmap-*
Browse files Browse the repository at this point in the history
These tests are confused, because -p does not change
the guest page size, but the host page size.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-25-richard.henderson@linaro.org>
  • Loading branch information
rth7680 committed Feb 29, 2024
1 parent eb5027a commit e920616
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 45 deletions.
3 changes: 0 additions & 3 deletions tests/tcg/alpha/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,3 @@ test-cmov: test-cond.c
$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)

run-test-cmov: test-cmov

# On Alpha Linux only supports 8k pages
EXTRA_RUNS+=run-test-mmap-8192
3 changes: 0 additions & 3 deletions tests/tcg/arm/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,3 @@ sha512-vector: sha512.c
ARM_TESTS += sha512-vector

TESTS += $(ARM_TESTS)

# On ARM Linux only supports 4k pages
EXTRA_RUNS+=run-test-mmap-4096
3 changes: 0 additions & 3 deletions tests/tcg/hppa/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
#
# HPPA specific tweaks - specifically masking out broken tests

# On parisc Linux supports 4K/16K/64K (but currently only 4k works)
EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536

# This triggers failures for hppa-linux about 1% of the time
# HPPA is the odd target that can't use the sigtramp page;
# it requires the full vdso with dwarf2 unwind info.
Expand Down
3 changes: 0 additions & 3 deletions tests/tcg/i386/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ endif
I386_TESTS:=$(filter-out $(SKIP_I386_TESTS), $(ALL_X86_TESTS))
TESTS=$(MULTIARCH_TESTS) $(I386_TESTS)

# On i386 and x86_64 Linux only supports 4k pages (large pages are a different hack)
EXTRA_RUNS+=run-test-mmap-4096

sha512-sse: CFLAGS=-msse4.1 -O3
sha512-sse: sha512.c
$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
Expand Down
3 changes: 0 additions & 3 deletions tests/tcg/m68k/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,3 @@

VPATH += $(SRC_PATH)/tests/tcg/m68k
TESTS += trap denormal

# On m68k Linux supports 4k and 8k pages (but 8k is currently broken)
EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-8192
9 changes: 0 additions & 9 deletions tests/tcg/multiarch/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,9 @@ run-plugin-vma-pthread-with-%: vma-pthread
$(call skip-test, $<, "flaky on CI?")
endif

# We define the runner for test-mmap after the individual
# architectures have defined their supported pages sizes. If no
# additional page sizes are defined we only run the default test.

# default case (host page size)
run-test-mmap: test-mmap
$(call run-test, test-mmap, $(QEMU) $<, $< (default))

# additional page sizes (defined by each architecture adding to EXTRA_RUNS)
run-test-mmap-%: test-mmap
$(call run-test, test-mmap-$*, $(QEMU) -p $* $<, $< ($* byte pages))

ifneq ($(GDB),)
GDB_SCRIPT=$(SRC_PATH)/tests/guest-debug/run-test.py

Expand Down
12 changes: 0 additions & 12 deletions tests/tcg/ppc/Makefile.target

This file was deleted.

3 changes: 0 additions & 3 deletions tests/tcg/sh4/Makefile.target
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
# SuperH specific tweaks
#

# On sh Linux supports 4k, 8k, 16k and 64k pages (but only 4k currently works)
EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-8192 run-test-mmap-16384 run-test-mmap-65536

# This triggers failures for sh4-linux about 10% of the time.
# Random SIGSEGV at unpredictable guest address, cause unknown.
run-signals: signals
Expand Down
6 changes: 0 additions & 6 deletions tests/tcg/sparc64/Makefile.target

This file was deleted.

0 comments on commit e920616

Please sign in to comment.