Skip to content

Commit

Permalink
dump: Fix HMP dump-guest-memory -z without -R
Browse files Browse the repository at this point in the history
-z without -R has no effect: the dump format remains @elf.  Fix the
logic error so it becomes @kdump-zlib.

Fixes: e654919 (dump: Add command interface for kdump-raw formats)
Fixes: CID 1523841
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
Markus Armbruster authored and Michael Tokarev committed Jan 30, 2024
1 parent 11be706 commit e999bea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dump/dump-hmp-cmds.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict)
dump_format = DUMP_GUEST_MEMORY_FORMAT_WIN_DMP;
}

if (zlib && raw) {
if (zlib) {
if (raw) {
dump_format = DUMP_GUEST_MEMORY_FORMAT_KDUMP_RAW_ZLIB;
} else {
Expand Down

0 comments on commit e999bea

Please sign in to comment.