Skip to content

Commit

Permalink
hw/sh4/r2d: use pci_init_nic_devices()
Browse files Browse the repository at this point in the history
Previously, the first PCI NIC would be assigned to slot 2 even if the
user override the model and made it something other than an rtl8139
which is the default. Everything else would be dynamically assigned.

Now, the first rtl8139 gets slot 2 and everything else is dynamic.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
  • Loading branch information
dwmw2 committed Feb 1, 2024
1 parent e794383 commit ea528f0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions hw/sh4/r2d.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ static void r2d_init(MachineState *machine)
MemoryRegion *sdram = g_new(MemoryRegion, 1);
qemu_irq *irq;
DriveInfo *dinfo;
int i;
DeviceState *dev;
SysBusDevice *busdev;
MemoryRegion *address_space_mem = get_system_memory();
Expand Down Expand Up @@ -309,9 +308,8 @@ static void r2d_init(MachineState *machine)
0x555, 0x2aa, 0);

/* NIC: rtl8139 on-board, and 2 slots. */
for (i = 0; i < nb_nics; i++)
pci_nic_init_nofail(&nd_table[i], pci_bus,
mc->default_nic, i == 0 ? "2" : NULL);
pci_init_nic_in_slot(pci_bus, mc->default_nic, NULL, "2");
pci_init_nic_devices(pci_bus, mc->default_nic);

/* USB keyboard */
usb_create_simple(usb_bus_find(-1), "usb-kbd");
Expand Down

0 comments on commit ea528f0

Please sign in to comment.