Skip to content

Commit

Permalink
9pfs: local: truncate: don't follow symlinks
Browse files Browse the repository at this point in the history
The local_truncate() callback is vulnerable to symlink attacks because
it calls truncate() which follows symbolic links in all path elements.

This patch converts local_truncate() to rely on open_nofollow() and
ftruncate() instead.

This partly fixes CVE-2016-9602.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit ac125d9)
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
  • Loading branch information
gkurz authored and mdroth committed Mar 16, 2017
1 parent d3c54bf commit ec10ead
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions hw/9pfs/9p-local.c
Expand Up @@ -895,13 +895,14 @@ static int local_link(FsContext *ctx, V9fsPath *oldpath,

static int local_truncate(FsContext *ctx, V9fsPath *fs_path, off_t size)
{
char *buffer;
int ret;
char *path = fs_path->data;
int fd, ret;

buffer = rpath(ctx, path);
ret = truncate(buffer, size);
g_free(buffer);
fd = local_open_nofollow(ctx, fs_path->data, O_WRONLY, 0);
if (fd == -1) {
return -1;
}
ret = ftruncate(fd, size);
close_preserve_errno(fd);
return ret;
}

Expand Down

0 comments on commit ec10ead

Please sign in to comment.