Skip to content

Commit

Permalink
Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull…
Browse files Browse the repository at this point in the history
…-request' into staging

Machine/NUMA fixes for -rc0

* Properly free device_memory at machine_finalize()
* Fix implicit NUMA initialization regression (for machines with
  auto_enable_numa_with_memhp=true)

# gpg: Signature made Mon 09 Jul 2018 18:40:38 BST
# gpg:                using RSA key 2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <ehabkost@redhat.com>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-next-pull-request:
  hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()
  machine: properly free device_memory

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
pm215 committed Jul 9, 2018
2 parents 3379c6c + 7747abf commit ed811be
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hw/core/machine.c
Expand Up @@ -674,6 +674,7 @@ static void machine_finalize(Object *obj)
g_free(ms->dumpdtb);
g_free(ms->dt_compatible);
g_free(ms->firmware);
g_free(ms->device_memory);
}

bool machine_usb(MachineState *machine)
Expand Down Expand Up @@ -791,10 +792,9 @@ void machine_run_board_init(MachineState *machine)
{
MachineClass *machine_class = MACHINE_GET_CLASS(machine);

if (nb_numa_nodes) {
numa_complete_configuration(machine);
numa_complete_configuration(machine);
if (nb_numa_nodes)
machine_numa_finish_cpu_init(machine);
}

/* If the machine supports the valid_cpu_types check and the user
* specified a CPU with -cpu check here that the user CPU is supported.
Expand Down

0 comments on commit ed811be

Please sign in to comment.