Skip to content

Commit

Permalink
qga: fix guest-get-disks regression
Browse files Browse the repository at this point in the history
Commit 54aa3de ("qapi: Use QAPI_LIST_PREPEND() where possible")
inadvertently removed the has_dependencies from the partition disk
info, resulting in empty list being returned.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210420125831.233092-1-marcandre.lureau@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
elmarco authored and pm215 committed Apr 20, 2021
1 parent ef71c1b commit efb596d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions qga/commands-posix.c
Expand Up @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions(
partition = g_new0(GuestDiskInfo, 1);
partition->name = dev_name;
partition->partition = true;
partition->has_dependencies = true;
/* Add parent disk as dependent for easier tracking of hierarchy */
QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev));

Expand Down

0 comments on commit efb596d

Please sign in to comment.