Skip to content

Commit

Permalink
disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
Browse files Browse the repository at this point in the history
Commit 8acc216 attempted to silence some sign-compare
warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
for the relevant objects. Unfortunately it was ineffective
because it was placed before $(QEMU_CFLAGS), so the -Wall in
the general flags overrode -Wno-sign-compare rather than
vice-versa. Reorder the flags so the warning suppression works.

Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
for pointing out what was wrong with the original patch.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 1452783202-576-1-git-send-email-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Jan 14, 2016
1 parent 17c8a21 commit f02ccf5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion disas/libvixl/Makefile.objs
Expand Up @@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \

# The -Wno-sign-compare is needed only for gcc 4.6, which complains about
# some signed-unsigned equality comparisons which later gcc versions do not.
$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare

common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)

0 comments on commit f02ccf5

Please sign in to comment.