Skip to content

Commit

Permalink
migration: Rename xbzrle_enabled xbzrle_started
Browse files Browse the repository at this point in the history
Otherwise it is confusing with the function xbzrle_enabled().

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230504115323.24407-1-quintela@redhat.com>
  • Loading branch information
Juan Quintela committed May 4, 2023
1 parent 40f240a commit f3095cc
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions migration/ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ struct RAMState {
uint64_t xbzrle_pages_prev;
/* Amount of xbzrle encoded bytes since the beginning of the period */
uint64_t xbzrle_bytes_prev;
/* Start using XBZRLE (e.g., after the first round). */
bool xbzrle_enabled;
/* Are we really using XBZRLE (e.g., after the first round). */
bool xbzrle_started;
/* Are we on the last stage of migration */
bool last_stage;
/* compression statistics since the beginning of the period */
Expand Down Expand Up @@ -1420,7 +1420,7 @@ static int ram_save_page(RAMState *rs, PageSearchStatus *pss)
trace_ram_save_page(block->idstr, (uint64_t)offset, p);

XBZRLE_cache_lock();
if (rs->xbzrle_enabled && !migration_in_postcopy()) {
if (rs->xbzrle_started && !migration_in_postcopy()) {
pages = save_xbzrle_page(rs, pss, &p, current_addr,
block, offset);
if (!rs->last_stage) {
Expand Down Expand Up @@ -1636,7 +1636,7 @@ static int find_dirty_block(RAMState *rs, PageSearchStatus *pss)
pss->complete_round = true;
/* After the first round, enable XBZRLE. */
if (migrate_xbzrle()) {
rs->xbzrle_enabled = true;
rs->xbzrle_started = true;
}
}
/* Didn't find anything this time, but try again on the new block */
Expand Down Expand Up @@ -2288,7 +2288,7 @@ static bool save_page_use_compression(RAMState *rs)
* using the data compression. In theory, xbzrle can do better than
* compression.
*/
if (rs->xbzrle_enabled) {
if (rs->xbzrle_started) {
return false;
}

Expand Down Expand Up @@ -2357,7 +2357,7 @@ static int ram_save_target_page_legacy(RAMState *rs, PageSearchStatus *pss)
/* Must let xbzrle know, otherwise a previous (now 0'd) cached
* page would be stale
*/
if (rs->xbzrle_enabled) {
if (rs->xbzrle_started) {
XBZRLE_cache_lock();
xbzrle_cache_zero_page(rs, block->offset + offset);
XBZRLE_cache_unlock();
Expand Down Expand Up @@ -2738,7 +2738,7 @@ static void ram_state_reset(RAMState *rs)
rs->last_seen_block = NULL;
rs->last_page = 0;
rs->last_version = ram_list.version;
rs->xbzrle_enabled = false;
rs->xbzrle_started = false;
}

#define MAX_WAIT 50 /* ms, half buffered_file limit */
Expand Down

0 comments on commit f3095cc

Please sign in to comment.