Skip to content

Commit

Permalink
tpm: lookup tpm backend class in tpm_driver_find_by_type()
Browse files Browse the repository at this point in the history
One step towards removing TPMDriverOps and driver registration.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
  • Loading branch information
elmarco authored and stefanberger committed Oct 19, 2017
1 parent 349ccdc commit f3faa1d
Showing 1 changed file with 21 additions and 8 deletions.
29 changes: 21 additions & 8 deletions tpm.c
Expand Up @@ -47,6 +47,24 @@ void tpm_register_driver(const TPMDriverOps *tdo)
be_drivers[tdo->type] = tdo;
}

static const TPMDriverOps *
tpm_driver_find_by_type(enum TpmType type)
{
ObjectClass *oc;
TPMBackendClass *bc;
char *typename = g_strdup_printf("tpm-%s", TpmType_str(type));

oc = object_class_by_name(typename);
g_free(typename);

if (!object_class_dynamic_cast(oc, TYPE_TPM_BACKEND)) {
return NULL;
}

bc = TPM_BACKEND_CLASS(oc);
return bc->ops;
}

/*
* Walk the list of available TPM backend drivers and display them on the
* screen.
Expand All @@ -58,11 +76,11 @@ static void tpm_display_backend_drivers(void)
fprintf(stderr, "Supported TPM types (choose only one):\n");

for (i = 0; i < TPM_TYPE__MAX; i++) {
if (be_drivers[i] == NULL) {
const TPMDriverOps *ops = tpm_driver_find_by_type(i);
if (!ops) {
continue;
}
fprintf(stderr, "%12s %s\n",
TpmType_str(i), be_drivers[i]->desc);
fprintf(stderr, "%12s %s\n", TpmType_str(i), ops->desc);
}
fprintf(stderr, "\n");
}
Expand Down Expand Up @@ -196,11 +214,6 @@ int tpm_config_parse(QemuOptsList *opts_list, const char *optarg)

#endif /* CONFIG_TPM */

static const TPMDriverOps *tpm_driver_find_by_type(enum TpmType type)
{
return be_drivers[type];
}

/*
* Walk the list of active TPM backends and collect information about them
* following the schema description in qapi-schema.json.
Expand Down

0 comments on commit f3faa1d

Please sign in to comment.