Skip to content

Commit

Permalink
ich9: call ich9_lpc_update_pic for disabled pirqs
Browse files Browse the repository at this point in the history
An asserted pirq can be disabled and the corresponding GSIs
should then go down to 0.  However, because of the conditional in
ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.

Reviewed-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Jun 29, 2016
1 parent f2dd8eb commit f62efca
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions hw/isa/lpc_ich9.c
Expand Up @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)

ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
if (pic_dis) {
return;
}

ich9_lpc_update_pic(lpc, pic_irq);
}
Expand Down

0 comments on commit f62efca

Please sign in to comment.