Skip to content

Commit

Permalink
tcg/ppc: Use PLD in tcg_out_movi for constant pool
Browse files Browse the repository at this point in the history
The prefixed instruction has a pc-relative form to use here.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  • Loading branch information
rth7680 committed Oct 18, 2023
1 parent 94fa412 commit f680f64
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions tcg/ppc/tcg-target.c.inc
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@
#define ALL_GENERAL_REGS 0xffffffffu
#define ALL_VECTOR_REGS 0xffffffff00000000ull

#ifndef R_PPC64_PCREL34
#define R_PPC64_PCREL34 132
#endif

#define have_isel (cpuinfo & CPUINFO_ISEL)

#ifndef CONFIG_SOFTMMU
Expand Down Expand Up @@ -266,6 +270,19 @@ static bool reloc_pc14(tcg_insn_unit *src_rw, const tcg_insn_unit *target)
return false;
}

static bool reloc_pc34(tcg_insn_unit *src_rw, const tcg_insn_unit *target)
{
const tcg_insn_unit *src_rx = tcg_splitwx_to_rx(src_rw);
ptrdiff_t disp = tcg_ptr_byte_diff(target, src_rx);

if (disp == sextract64(disp, 0, 34)) {
src_rw[0] = (src_rw[0] & ~0x3ffff) | ((disp >> 16) & 0x3ffff);
src_rw[1] = (src_rw[1] & ~0xffff) | (disp & 0xffff);
return true;
}
return false;
}

/* test if a constant matches the constraint */
static bool tcg_target_const_match(int64_t val, TCGType type, int ct, int vece)
{
Expand Down Expand Up @@ -696,6 +713,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
return reloc_pc14(code_ptr, target);
case R_PPC_REL24:
return reloc_pc24(code_ptr, target);
case R_PPC64_PCREL34:
return reloc_pc34(code_ptr, target);
case R_PPC_ADDR16:
/*
* We are (slightly) abusing this relocation type. In particular,
Expand Down Expand Up @@ -1155,6 +1174,11 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type, TCGReg ret,
tcg_out32(s, LD | TAI(ret, TCG_REG_TB, 0));
return;
}
if (have_isa_3_10) {
tcg_out_8ls_d(s, PLD, ret, 0, 0, 1);
new_pool_label(s, arg, R_PPC64_PCREL34, s->code_ptr - 2, 0);
return;
}
if (have_isa_3_00) {
tcg_out_addpcis(s, TCG_REG_TMP2, 0);
new_pool_label(s, arg, R_PPC_REL14, s->code_ptr, 0);
Expand Down

0 comments on commit f680f64

Please sign in to comment.