Skip to content

Commit

Permalink
s390x/event-facility: fix location of receive mask
Browse files Browse the repository at this point in the history
For read event mask, we assumed that the layout of the sccb was

|sccb header|event buffer header|receive mask|...|

The correct layout, however, is

|sccb header|receive mask|...|

as in-buffer and

|sccb header|event buffer header|...|

as out-buffer.

Fix this: This makes selective read work.

Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
  • Loading branch information
cohuck committed Sep 7, 2015
1 parent 6b7741c commit f7822aa
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions include/hw/s390x/event-facility.h
Expand Up @@ -146,8 +146,10 @@ typedef struct WriteEventData {

typedef struct ReadEventData {
SCCBHeader h;
EventBufferHeader ebh;
uint32_t mask;
union {
uint32_t mask;
EventBufferHeader ebh;
};
} QEMU_PACKED ReadEventData;

typedef struct SCLPEvent {
Expand Down

0 comments on commit f7822aa

Please sign in to comment.