Skip to content

Commit

Permalink
virtio-net: remove layout assumptions for mq ctrl
Browse files Browse the repository at this point in the history
Following commit 921ac5d (virtio-net:
remove layout assumptions for ctrl vq), this patch makes multiqueue ctrl
handling not rely on the layout of descriptors.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
jasowang authored and mstsirkin committed Mar 26, 2013
1 parent 15054fc commit f8f7c53
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions hw/virtio-net.c
Expand Up @@ -578,30 +578,31 @@ static int virtio_net_handle_vlan_table(VirtIONet *n, uint8_t cmd,
}

static int virtio_net_handle_mq(VirtIONet *n, uint8_t cmd,
VirtQueueElement *elem)
struct iovec *iov, unsigned int iov_cnt)
{
struct virtio_net_ctrl_mq s;
struct virtio_net_ctrl_mq mq;
size_t s;
uint16_t queues;

if (elem->out_num != 2 ||
elem->out_sg[1].iov_len != sizeof(struct virtio_net_ctrl_mq)) {
error_report("virtio-net ctrl invalid steering command");
s = iov_to_buf(iov, iov_cnt, 0, &mq, sizeof(mq));
if (s != sizeof(mq)) {
return VIRTIO_NET_ERR;
}

if (cmd != VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET) {
return VIRTIO_NET_ERR;
}

memcpy(&s, elem->out_sg[1].iov_base, sizeof(struct virtio_net_ctrl_mq));
queues = lduw_p(&mq.virtqueue_pairs);

if (s.virtqueue_pairs < VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN ||
s.virtqueue_pairs > VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX ||
s.virtqueue_pairs > n->max_queues ||
if (queues < VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN ||
queues > VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX ||
queues > n->max_queues ||
!n->multiqueue) {
return VIRTIO_NET_ERR;
}

n->curr_queues = s.virtqueue_pairs;
n->curr_queues = queues;
/* stop the backend before changing the number of queues to avoid handling a
* disabled queue */
virtio_net_set_status(&n->vdev, n->vdev.status);
Expand Down Expand Up @@ -639,7 +640,7 @@ static void virtio_net_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq)
} else if (ctrl.class == VIRTIO_NET_CTRL_VLAN) {
status = virtio_net_handle_vlan_table(n, ctrl.cmd, iov, iov_cnt);
} else if (ctrl.class == VIRTIO_NET_CTRL_MQ) {
status = virtio_net_handle_mq(n, ctrl.cmd, &elem);
status = virtio_net_handle_mq(n, ctrl.cmd, iov, iov_cnt);
}

s = iov_from_buf(elem.in_sg, elem.in_num, 0, &status, sizeof(status));
Expand Down

0 comments on commit f8f7c53

Please sign in to comment.