Skip to content

Commit

Permalink
target-xtensa: fix extui shift amount
Browse files Browse the repository at this point in the history
extui opcode only uses lowermost op1 bit for sa4.

Reported-by: malc <av1474@comtv.ru>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: malc <av1474@comtv.ru>
  • Loading branch information
jcmvbkbc authored and malc committed Sep 20, 2012
1 parent a255066 commit f9cb504
Showing 1 changed file with 21 additions and 3 deletions.
24 changes: 21 additions & 3 deletions target-xtensa/translate.c
Expand Up @@ -1778,12 +1778,30 @@ static void disas_xtensa_insn(DisasContext *dc)
case 5:
gen_window_check2(dc, RRR_R, RRR_T);
{
int shiftimm = RRR_S | (OP1 << 4);
int shiftimm = RRR_S | ((OP1 & 1) << 4);
int maskimm = (1 << (OP2 + 1)) - 1;

TCGv_i32 tmp = tcg_temp_new_i32();
tcg_gen_shri_i32(tmp, cpu_R[RRR_T], shiftimm);
tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm);

if (shiftimm) {
tcg_gen_shri_i32(tmp, cpu_R[RRR_T], shiftimm);
} else {
tcg_gen_mov_i32(tmp, cpu_R[RRR_T]);
}

switch (maskimm) {
case 0xff:
tcg_gen_ext8u_i32(cpu_R[RRR_R], tmp);
break;

case 0xffff:
tcg_gen_ext16u_i32(cpu_R[RRR_R], tmp);
break;

default:
tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm);
break;
}
tcg_temp_free(tmp);
}
break;
Expand Down

0 comments on commit f9cb504

Please sign in to comment.