Skip to content

Commit

Permalink
migration: drop MADVISE_DONT_NEED for incoming zero pages
Browse files Browse the repository at this point in the history
The madvise for zeroed out pages was introduced when every transferred
zero page was memset to zero and thus allocated. Since commit
211ea74 we check for zeroness of a target page before we memset
it to zero. Additionally we memmap target memory so it is essentially
zero initialized (except for e.g. option roms and bios which are loaded
into target memory although they shouldn't).

It was reported recently that this madvise causes a performance degradation
in some situations. As the madvise should only be called rarely and if it's called
it is likely on a busy page (it was non-zero and changed to zero during migration)
drop it completely.

Reported-By: Zhang Haoyu <haoyu.zhang@huawei.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
plieven authored and Juan Quintela committed Nov 19, 2013
1 parent 5c5432e commit fc1c4a5
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions arch_init.c
Expand Up @@ -850,14 +850,6 @@ void ram_handle_compressed(void *host, uint8_t ch, uint64_t size)
{
if (ch != 0 || !is_zero_range(host, size)) {
memset(host, ch, size);
#ifndef _WIN32
if (ch == 0 && (!kvm_enabled() || kvm_has_sync_mmu())) {
size = size & ~(getpagesize() - 1);
if (size > 0) {
qemu_madvise(host, size, QEMU_MADV_DONTNEED);
}
}
#endif
}
}

Expand Down

0 comments on commit fc1c4a5

Please sign in to comment.