Merge pull request #1 from qemu/master #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch to lastest QEMU
0day-ci
pushed a commit
to 0day-ci/qemu
that referenced
this pull request
Aug 9, 2016
2016-08-09 08:31-0700, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Message-id: 20160809150333.9991-1-rkrcmar@redhat.com > Type: series > Subject: [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to quirkless KVM > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > e018fb0 intel-iommu: restrict EIM to quirkless KVM > 5ef6f2f linux-headers: update to v4.8-rc1 > > === OUTPUT BEGIN === > Checking PATCH 1/2: linux-headers: update to v4.8-rc1... > ERROR: code indent should never use tabs > qemu#32: FILE: linux-headers/linux/kvm.h:885: > +^Iunion {$ > > ERROR: code indent should never use tabs > qemu#33: FILE: linux-headers/linux/kvm.h:886: > +^I^I__u32 pad;$ > > ERROR: code indent should never use tabs > qemu#34: FILE: linux-headers/linux/kvm.h:887: > +^I^I__u32 devid;$ > > ERROR: code indent should never use tabs > qemu#35: FILE: linux-headers/linux/kvm.h:888: > +^I};$ > > ERROR: code indent should never use tabs > qemu#43: FILE: linux-headers/linux/kvm.h:1034: > +#define KVM_MSI_VALID_DEVID^I(1U << 0)$ > > ERROR: code indent should never use tabs > qemu#50: FILE: linux-headers/linux/kvm.h:1040: > +^I__u32 devid;$ > > ERROR: code indent should never use tabs > qemu#51: FILE: linux-headers/linux/kvm.h:1041: > +^I__u8 pad[12];$ > > ERROR: code indent should never use tabs > qemu#59: FILE: linux-headers/linux/kvm.h:1086: > +^IKVM_DEV_TYPE_ARM_VGIC_ITS,$ > > ERROR: code indent should never use tabs > qemu#60: FILE: linux-headers/linux/kvm.h:1087: > +#define KVM_DEV_TYPE_ARM_VGIC_ITS^IKVM_DEV_TYPE_ARM_VGIC_ITS$ > > total: 9 errors, 0 warnings, 51 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. These indentation errors are false positives. ---8<--- Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of changing scripts/update-linux-headers.sh to expand tabs when importing. Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
brooksdavis
pushed a commit
to brooksdavis/qemu
that referenced
this pull request
Jun 7, 2017
Fix typo in fork_end() in bsd-user/main.c.
famz
pushed a commit
to famz/qemu
that referenced
this pull request
Sep 28, 2018
Both virtio-blk and virtio-scsi use virtio_queue_empty() as the
loop condition in VQ handlers (virtio_blk_handle_vq,
virtio_scsi_handle_cmd_vq). When a device is marked broken in
virtqueue_pop, for example if a vIOMMU address translation failed, we
want to break out of the loop.
This fixes a hanging problem when booting a CentOS 3.10.0-862.el7.x86_64
kernel:
$ qemu-system-x86_64 \
... \
-device intel-iommu,intremap=on,caching-mode=on,eim=on,device-iotlb=on \
-device virtio-scsi-pci,iommu_platform=on,ats=on,id=scsi0,bus=pci.4,addr=0x0
The dead loop happens immediately when the kernel boots and initializes
the device, where virtio_scsi_data_plane_handle_cmd will not return:
> ...
> qemu#13 0x00005586602b7793 in virtio_scsi_handle_cmd_vq
> qemu#14 0x00005586602b8d66 in virtio_scsi_data_plane_handle_cmd
> qemu#15 0x00005586602ddab7 in virtio_queue_notify_aio_vq
> qemu#16 0x00005586602dfc9f in virtio_queue_host_notifier_aio_poll
> qemu#17 0x00005586607885da in run_poll_handlers_once
> qemu#18 0x000055866078880e in try_poll_mode
> qemu#19 0x00005586607888eb in aio_poll
> qemu#20 0x0000558660784561 in aio_wait_bh_oneshot
> qemu#21 0x00005586602b9582 in virtio_scsi_dataplane_stop
> qemu#22 0x00005586605a7110 in virtio_bus_stop_ioeventfd
> qemu#23 0x00005586605a9426 in virtio_pci_stop_ioeventfd
> qemu#24 0x00005586605ab808 in virtio_pci_common_write
> qemu#25 0x0000558660242396 in memory_region_write_accessor
> qemu#26 0x00005586602425ab in access_with_adjusted_size
> qemu#27 0x0000558660245281 in memory_region_dispatch_write
> qemu#28 0x00005586601e008e in flatview_write_continue
> qemu#29 0x00005586601e01d8 in flatview_write
> qemu#30 0x00005586601e04de in address_space_write
> qemu#31 0x00005586601e052f in address_space_rw
> qemu#32 0x00005586602607f2 in kvm_cpu_exec
> qemu#33 0x0000558660227148 in qemu_kvm_cpu_thread_fn
> qemu#34 0x000055866078bde7 in qemu_thread_start
> qemu#35 0x00007f5784906594 in start_thread
> qemu#36 0x00007f5784639e6f in clone
With this patch, virtio_queue_empty will now return 1 as soon as the
vdev is marked as broken, after a "virtio: zero sized buffers are not
allowed" error.
To be consistent, update virtio_queue_empty_rcu as well.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
v2: - Drop ATS condition from the patch description since it is not
essential.
- Drop patch 2. [Paolo]
qemu-deploy
pushed a commit
that referenced
this pull request
Oct 3, 2018
Both virtio-blk and virtio-scsi use virtio_queue_empty() as the
loop condition in VQ handlers (virtio_blk_handle_vq,
virtio_scsi_handle_cmd_vq). When a device is marked broken in
virtqueue_pop, for example if a vIOMMU address translation failed, we
want to break out of the loop.
This fixes a hanging problem when booting a CentOS 3.10.0-862.el7.x86_64
kernel with ATS enabled:
$ qemu-system-x86_64 \
... \
-device intel-iommu,intremap=on,caching-mode=on,eim=on,device-iotlb=on \
-device virtio-scsi-pci,iommu_platform=on,ats=on,id=scsi0,bus=pci.4,addr=0x0
The dead loop happens immediately when the kernel boots and initializes
the device, where virtio_scsi_data_plane_handle_cmd will not return:
> ...
> #13 0x00005586602b7793 in virtio_scsi_handle_cmd_vq
> #14 0x00005586602b8d66 in virtio_scsi_data_plane_handle_cmd
> #15 0x00005586602ddab7 in virtio_queue_notify_aio_vq
> #16 0x00005586602dfc9f in virtio_queue_host_notifier_aio_poll
> #17 0x00005586607885da in run_poll_handlers_once
> #18 0x000055866078880e in try_poll_mode
> #19 0x00005586607888eb in aio_poll
> #20 0x0000558660784561 in aio_wait_bh_oneshot
> #21 0x00005586602b9582 in virtio_scsi_dataplane_stop
> #22 0x00005586605a7110 in virtio_bus_stop_ioeventfd
> #23 0x00005586605a9426 in virtio_pci_stop_ioeventfd
> #24 0x00005586605ab808 in virtio_pci_common_write
> #25 0x0000558660242396 in memory_region_write_accessor
> #26 0x00005586602425ab in access_with_adjusted_size
> #27 0x0000558660245281 in memory_region_dispatch_write
> #28 0x00005586601e008e in flatview_write_continue
> #29 0x00005586601e01d8 in flatview_write
> #30 0x00005586601e04de in address_space_write
> #31 0x00005586601e052f in address_space_rw
> #32 0x00005586602607f2 in kvm_cpu_exec
> #33 0x0000558660227148 in qemu_kvm_cpu_thread_fn
> #34 0x000055866078bde7 in qemu_thread_start
> #35 0x00007f5784906594 in start_thread
> #36 0x00007f5784639e6f in clone
With this patch, virtio_queue_empty will now return 1 as soon as the
vdev is marked as broken, after a "virtio: zero sized buffers are not
allowed" error.
To be consistent, update virtio_queue_empty_rcu as well.
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20180910145616.8598-2-famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
pranith
pushed a commit
to pranith/qemu
that referenced
this pull request
Oct 8, 2018
Both virtio-blk and virtio-scsi use virtio_queue_empty() as the
loop condition in VQ handlers (virtio_blk_handle_vq,
virtio_scsi_handle_cmd_vq). When a device is marked broken in
virtqueue_pop, for example if a vIOMMU address translation failed, we
want to break out of the loop.
This fixes a hanging problem when booting a CentOS 3.10.0-862.el7.x86_64
kernel with ATS enabled:
$ qemu-system-x86_64 \
... \
-device intel-iommu,intremap=on,caching-mode=on,eim=on,device-iotlb=on \
-device virtio-scsi-pci,iommu_platform=on,ats=on,id=scsi0,bus=pci.4,addr=0x0
The dead loop happens immediately when the kernel boots and initializes
the device, where virtio_scsi_data_plane_handle_cmd will not return:
> ...
> qemu#13 0x00005586602b7793 in virtio_scsi_handle_cmd_vq
> qemu#14 0x00005586602b8d66 in virtio_scsi_data_plane_handle_cmd
> qemu#15 0x00005586602ddab7 in virtio_queue_notify_aio_vq
> qemu#16 0x00005586602dfc9f in virtio_queue_host_notifier_aio_poll
> qemu#17 0x00005586607885da in run_poll_handlers_once
> qemu#18 0x000055866078880e in try_poll_mode
> qemu#19 0x00005586607888eb in aio_poll
> qemu#20 0x0000558660784561 in aio_wait_bh_oneshot
> qemu#21 0x00005586602b9582 in virtio_scsi_dataplane_stop
> qemu#22 0x00005586605a7110 in virtio_bus_stop_ioeventfd
> qemu#23 0x00005586605a9426 in virtio_pci_stop_ioeventfd
> qemu#24 0x00005586605ab808 in virtio_pci_common_write
> qemu#25 0x0000558660242396 in memory_region_write_accessor
> qemu#26 0x00005586602425ab in access_with_adjusted_size
> qemu#27 0x0000558660245281 in memory_region_dispatch_write
> qemu#28 0x00005586601e008e in flatview_write_continue
> qemu#29 0x00005586601e01d8 in flatview_write
> qemu#30 0x00005586601e04de in address_space_write
> qemu#31 0x00005586601e052f in address_space_rw
> qemu#32 0x00005586602607f2 in kvm_cpu_exec
> qemu#33 0x0000558660227148 in qemu_kvm_cpu_thread_fn
> qemu#34 0x000055866078bde7 in qemu_thread_start
> qemu#35 0x00007f5784906594 in start_thread
> qemu#36 0x00007f5784639e6f in clone
With this patch, virtio_queue_empty will now return 1 as soon as the
vdev is marked as broken, after a "virtio: zero sized buffers are not
allowed" error.
To be consistent, update virtio_queue_empty_rcu as well.
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20180910145616.8598-2-famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
Thank you for your interest in the QEMU project. This repository is a read-only mirror of the project's master QEMU welcomes contributions of code (either fixing bugs or adding new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch to lastest QEMU