Fix node5 incompatibility (#285)

qetza · Oct 8, 2022 · 7b178df · 7b178df
1 parent dd2c2e3
commit 7b178df
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -95,6 +95,12 @@ If you want to use tokens in XML based configuration files to be replaced during
   - replace tokens in your updated configuration file
 
 ## Release notes
+**New in 4.4.1**
+- Task **4.2.1**
+  - Fix compatibility with node 5.10.1 ([#277](https://github.com/qetza/vsts-replacetokens-task/issues/277)).
+- Task **3.10.1**
+  - Fix compatibility with node 5.10.1 ([#277](https://github.com/qetza/vsts-replacetokens-task/issues/277)).
+
 **New in 4.4.0**
 - Task **5.1.0**
   - Add support for inline variables ([#252](https://github.com/qetza/vsts-replacetokens-task/issues/252)).

diff --git a/tasks/ReplaceTokensV3/README.md b/tasks/ReplaceTokensV3/README.md
@@ -84,6 +84,9 @@ If you want to use tokens in XML based configuration files to be replaced during
   - replace tokens in your updated configuration file
 
 ## Release notes
+**New in 3.10.1**
+- Fix compatibility with node 5.10.1 ([#277](https://github.com/qetza/vsts-replacetokens-task/issues/277)).
+
 **New in 3.10.0**
 - Add support for inline variables ([#252](https://github.com/qetza/vsts-replacetokens-task/issues/252)).
 - Add support for recursive token replacement in values ([#201](https://github.com/qetza/vsts-replacetokens-task/issues/201)).

diff --git a/tasks/ReplaceTokensV3/index.ts b/tasks/ReplaceTokensV3/index.ts
@@ -250,8 +250,9 @@ var replaceTokensInString = function (
     enableEscape: boolean,
     escapeType: string,
     counter: Counter,
-    names: string[] = []): string {
+    names: string[]): string {
 
+    names = names || [];
     content = content.replace(regex, (match, name) => {
         ++counter.Tokens;
 
@@ -448,7 +449,7 @@ var replaceTokensInFile = function (
         let localCounter: Counter = new Counter();
         let content: string = iconv.decode(fs.readFileSync(filePath), encoding);
 
-        content = replaceTokensInString(content, regex, transformRegex, options, true, escapeType, localCounter);
+        content = replaceTokensInString(content, regex, transformRegex, options, true, escapeType, localCounter, []);
 
         // ensure outputPath directory exists
         let mkdirSyncRecursive = function (p: string) {

diff --git a/tasks/ReplaceTokensV3/task.json b/tasks/ReplaceTokensV3/task.json
@@ -13,7 +13,7 @@
     "version": {
         "Major": 3,
         "Minor": 10,
-        "Patch": 0
+        "Patch": 1
     },
     "instanceNameFormat": "Replace tokens in $(targetFiles)",
     "minimumAgentVersion": "2.105.0",

diff --git a/tasks/ReplaceTokensV4/README.md b/tasks/ReplaceTokensV4/README.md
@@ -93,6 +93,9 @@ If you want to use tokens in XML based configuration files to be replaced during
   - replace tokens in your updated configuration file
 
 ## Release notes
+**New in 4.2.1**
+- Fix compatibility with node 5.10.1 ([#277](https://github.com/qetza/vsts-replacetokens-task/issues/277)).
+
 **New in 4.2.0**
 - Add support for inline variables ([#252](https://github.com/qetza/vsts-replacetokens-task/issues/252)).
 - Add support for recursive token replacement in values ([#201](https://github.com/qetza/vsts-replacetokens-task/issues/201)).

diff --git a/tasks/ReplaceTokensV4/index.ts b/tasks/ReplaceTokensV4/index.ts
@@ -250,8 +250,9 @@ var replaceTokensInString = function (
     enableEscape: boolean,
     escapeType: string,
     counter: Counter,
-    names: string[] = []): string {
+    names: string[]): string {
 
+    names = names || [];
     content = content.replace(regex, (match, name) => {
         ++counter.Tokens;
 
@@ -448,7 +449,7 @@ var replaceTokensInFile = function (
         let localCounter: Counter = new Counter();
         let content: string = iconv.decode(fs.readFileSync(filePath), encoding);
 
-        content = replaceTokensInString(content, regex, transformRegex, options, true, escapeType, localCounter);
+        content = replaceTokensInString(content, regex, transformRegex, options, true, escapeType, localCounter, []);
 
         // ensure outputPath directory exists
         let mkdirSyncRecursive = function (p: string) {

diff --git a/tasks/ReplaceTokensV4/task.json b/tasks/ReplaceTokensV4/task.json
@@ -13,7 +13,7 @@
     "version": {
         "Major": 4,
         "Minor": 2,
-        "Patch": 0
+        "Patch": 1
     },
     "releaseNotes": "Added output variables (breaking change).<br/>Added token pattern dropdown (breaking change).",
     "instanceNameFormat": "Replace tokens in $(targetFiles)",

diff --git a/vss-extension.json b/vss-extension.json
@@ -2,7 +2,7 @@
   "manifestVersion": 1,
   "id": "replacetokens",
   "name": "Replace Tokens",
-  "version": "4.4.0",
+  "version": "4.4.1",
   "public": true,
   "publisher": "qetza",
   "targets": [