-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set any project path by default #137
base: master
Are you sure you want to change the base?
Conversation
This commit removes the auto directory change on the project. To change the path where to execute the hooks, a `project_path` config will need to be set. This commit can potentially break a current setup for a project that is relying on the _auto cd_.
Thanks for looking at this, Adrián! I just gave this another try and noticed the same thing as I mentioned on #123. Checking out my project freshly and setting the git_hooks dep in mix.exs with 'github' and 'branch' set to this PR, 'mix compile' shows the installing message, but at the end, my
I even looked at your diff here and tried swapping back the line in However, if I then switch back to I can't seem to even theorize what would make the difference! ... |
That is weird, @djthread can you please add the I've just tried on a fresh install and it worked fine. Just to be clear, the hooks install will only occur when the dep is compiled or when you execute |
Hi @qgadrian Thanks for working on this fix. I've pulled this PR and the auto installation is working as expected when specifying the project's root 👍
Would really appreciate if included in the next version release, cheers! |
Thanks for the feedback. Do you need to explicitly specify the IMO this dependency should work out of the box with _default project architecture, and use that option only for edge cases. That means, without setting |
Yes we had to specifically set it. Perhaps it's due to having multiple config files (
|
Hi @qgadrian, the problem seems to be here:
During auto install, I couldn't figure out what's the purpose of When running Can you double check this and provide some details please. Thanks |
This PR removes the auto directory change on the project. To change the path where to execute the hooks, a
project_path
config will need to be set.The changes here can potentially break a current setup for a project that is relying on the auto cd.
Fixes #123 #133