Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for env vars #30

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Added support for env vars #30

merged 3 commits into from
Dec 9, 2019

Conversation

akoutmos
Copy link
Contributor

This allows tasks to have environment variables passed to them so you can do things like the following and ensure that the proper items are in place before running tests:

tasks: [
  {:cmd, "mix ecto.setup", env: [{"MIX_ENV", "test"}]},
  "mix test"
]

If no args are passed, and empty list is provided to System.cmd/3

@coveralls
Copy link

coveralls commented Nov 13, 2019

Pull Request Test Coverage Report for Build 143

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 83.051%

Totals Coverage Status
Change from base Build 142: 0.6%
Covered Lines: 49
Relevant Lines: 59

💛 - Coveralls

@akoutmos
Copy link
Contributor Author

Friendly bump :)

@qgadrian
Copy link
Owner

Hey @akoutmos sorry I didn't have to take a look at this, I want to get ride of the TODO in the code instead of allowing it on credo.

I will merge it ASAP, thanks for the contribution! 🎉

@akoutmos
Copy link
Contributor Author

Thanks for getting back to me! Are you talking about this one? https://github.com/qgadrian/elixir_git_hooks/blob/master/lib/mix/tasks/git_hooks/run.ex#L77

@akoutmos
Copy link
Contributor Author

akoutmos commented Dec 5, 2019

Want me to remove the TODO in this PR?

@qgadrian
Copy link
Owner

qgadrian commented Dec 7, 2019

@akoutmos, please do. I updated master branch with the deprecation so no more TODOs pending anymore

@akoutmos
Copy link
Contributor Author

akoutmos commented Dec 9, 2019

Reverted the credo change. Let me know if there is anything else you would like me to do :)

@qgadrian qgadrian merged commit fa22c52 into qgadrian:master Dec 9, 2019
@qgadrian
Copy link
Owner

qgadrian commented Dec 9, 2019

Thanks for the contribution @akoutmos 🎉

@akoutmos
Copy link
Contributor Author

No problem :). Thanks for the awesome lib!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants