Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB3-zoo has models for v1 tasks but only registration specs for v2 tasks #26

Closed
dirkmcpherson opened this issue May 9, 2022 · 3 comments
Labels
question Further information is requested

Comments

@dirkmcpherson
Copy link

Hi, I'm trying to get a SB3 model to train the harder tasks (so far I've failed with SAC+HER), so I went to SB3-zoo to see some examples of successful models. I can't get them to load, and it looks like its because zoo has trained models for the v1 versions, but only has the v2 environments registered. Do you have successful trained V2 models you can push to zoo / did you successfully train any SB3 models out of the box on the v2 versions of the task?

thanks for making this environment!

@dirkmcpherson dirkmcpherson added the question Further information is requested label May 9, 2022
@dirkmcpherson
Copy link
Author

dirkmcpherson commented May 9, 2022

FYI you can get around this by replacing the "1" with a "2" in the env_id after the model is loaded in enjoy.py for the "ExperimentManager.is_atari" check and then in the "create_test_env" call.

The model successfully runs and has some success on the task (for pick and place anyway)

@qgallouedec
Copy link
Owner

qgallouedec commented May 10, 2022

Indeed.

First of all, this issue would be more appropriate in sb3-zoo than here. I will answer it anyway.

I am updating the sb3-zoo baselines for the v2 version of panda-gym. I should open a PR on sb3-zoo soon. I will put the link to the PR here when it is opened.

For the tasks already present in v1, the changes are quite small : it's mostly about some physical parameters like friction. So it should be possible to just replace v1 by v2 in the model loading without major trouble.

Be careful though, if you do that, you will necessarily get worse results than if you use a model trained with v2

@qgallouedec
Copy link
Owner

qgallouedec commented May 13, 2022

I am updating the sb3-zoo baselines for the v2 version of panda-gym. I should open a PR on sb3-zoo soon. I will put the link to the PR here when it is opened.

DLR-RM/rl-baselines3-zoo#244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants