Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panda-gym v2 #244

Closed
wants to merge 19 commits into from
Closed

panda-gym v2 #244

wants to merge 19 commits into from

Conversation

qgallouedec
Copy link
Collaborator

Description

Update benchmark for latest version of panda-gym.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member

araffin commented May 16, 2022

Hey,

thanks for the PR =)
I might wait until Huggingface PR is merged #198
I will help @simoninithomas in the coming days.

@araffin
Copy link
Member

araffin commented May 16, 2022

Quickly looking at it, no additional tuning was in fact required?

@qgallouedec
Copy link
Collaborator Author

no additional tuning was in fact required?

No tuning has been done. It might be possible to find better hyperparameters. I leave this for a future PR.
One exception: I had to decrease the learning for PickAndPlace with SAC. Otherwise, the loss was diverging.

@araffin
Copy link
Member

araffin commented May 20, 2022

Basic version is ready to review ;)
#250

An example: https://huggingface.co/sb3/ppo-MountainCarContinuous-v0

@araffin
Copy link
Member

araffin commented Jun 2, 2022

btw, this requires gym > 0.21, right?

@qgallouedec
Copy link
Collaborator Author

btw, this requires gym > 0.21, right?

Yes, so it can't be merged before #256 I think

@fikricanozgur
Copy link

What's the status with this PR?

@qgallouedec
Copy link
Collaborator Author

panda-gym v2 requires gym==0.24. But, for the moment, SB3 requires gym==0.21. So the status is "waiting for SB3 to be compatible with gym>=0.24"

@qgallouedec qgallouedec marked this pull request as draft December 12, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants