-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panda-gym v2 #244
panda-gym v2 #244
Conversation
Hey, thanks for the PR =) |
Quickly looking at it, no additional tuning was in fact required? |
No tuning has been done. It might be possible to find better hyperparameters. I leave this for a future PR. |
Basic version is ready to review ;) An example: https://huggingface.co/sb3/ppo-MountainCarContinuous-v0 |
btw, this requires gym > 0.21, right? |
Yes, so it can't be merged before #256 I think |
What's the status with this PR? |
panda-gym v2 requires gym==0.24. But, for the moment, SB3 requires gym==0.21. So the status is "waiting for SB3 to be compatible with gym>=0.24" |
Description
Update benchmark for latest version of panda-gym.
Motivation and Context
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line