Fix #10713 Sort plugins in a case-insensitive manner. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| # Average vote is not a field! | ||
| _sort_by == 'average_vote' or self.model._meta.get_field(_sort_by) | ||
|
|
There was a problem hiding this comment.
I'd stick to the try/except or we'll get ton of errors, this parameter comes straight from the query string.
There was a problem hiding this comment.
Right. I'll fix it later today
There was a problem hiding this comment.
@elpaso I just addressed your concern about that
elpaso
added a commit
that referenced
this pull request
Feb 2, 2016
Fix #10713 Sort plugins in a case-insensitive manner.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @elpaso @pcav @timlinux, this PR will fix http://hub.qgis.org/issues/10713.
At first, I could not replicate the issue. But then I realized that the database in the production server must be in C collation. This PR is not needed if you want to change the collation of the production database.
Thanks