Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Owners' by 'Collaborators' #254

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

gacarrillor
Copy link
Member

The word 'Owner' seems to be even more powerful than the other roles. Namely, 'Authors' and 'Maintainers'.
'Collaborator' fits better with the original intention, i.e., enable teammates to collaborate uploading newer plugin versions.

Note this just replaces the alias and doesn't touch the model.

@gacarrillor
Copy link
Member Author

@dimasciput, are test failures my fault? :)

@faebebin
Copy link
Contributor

faebebin commented Aug 21, 2022

@gacarrillor maybe just try to reopen the PR? What would you think about including https://pre-commit.com/ to avoid such errors in the future?

@dimasciput
Copy link
Collaborator

@gacarrillor maybe just try to reopen the PR? What would you think about including https://pre-commit.com/ to avoid such errors in the future?

that's a good idea, we can add that.

@gacarrillor gacarrillor reopened this Aug 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #254 (4ed8484) into master (ac26d15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   37.72%   37.72%           
=======================================
  Files          88       88           
  Lines        3714     3714           
=======================================
  Hits         1401     1401           
  Misses       2313     2313           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gacarrillor
Copy link
Member Author

@gacarrillor maybe just try to reopen the PR?

Yes, now tests are passing 👍

What would you think about including https://pre-commit.com/ to avoid such errors in the future?

It sounds good to have a pre-commit check.

Nonetheless, the error my PR was getting, namely:

./qgis-app/plugins/validator.py:76:15: E275 missing whitespace after keyword
./qgis-app/plugins/templatetags/plugins_tagcloud.py:75:7: E275 missing whitespace after keyword
Error: Process completed with exit code 1.

... is totally unrelated to the code (not really code) changes I'm suggesting. 😛

@dimasciput
Copy link
Collaborator

Hi @gacarrillor, can you rebase first please.

The word 'Owner' seems to be even more powerful than the other roles. Namely, 'Authors' and 'Maintainers'.
'Collaborator' fits better with the original intention, i.e., enable teammates to collaborate uploading newer plugin versions.

Note this just replaces the alias and doesn't touch the model.
@gacarrillor
Copy link
Member Author

Hi @gacarrillor, can you rebase first please.

Hi @dimasciput, sure!

@dimasciput
Copy link
Collaborator

@gacarrillor thanks, this looks good

@dimasciput dimasciput merged commit ade600c into qgis:master Aug 24, 2022
@gacarrillor gacarrillor deleted the patch-1 branch August 24, 2022 12:00
@gacarrillor
Copy link
Member Author

@gacarrillor thanks, this looks good

Thank you @dimasciput and thanks to @elpaso for his help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants