Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable matomo cookies tracking #333

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 22, 2023

This PR addresses the following comment: #320 (comment)

Changes summary

  • Disable matomo cookies tracking to keep the cookie disclaimer

Please find below the screenshot of cookies before and after disabling matomo cookies

Matomo_cookies Matomo_cookies_disabled

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d27e30b) 36.84% compared to head (60bfee9) 81.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #333       +/-   ##
===========================================
+ Coverage   36.84%   81.96%   +45.11%     
===========================================
  Files         103      139       +36     
  Lines        4429     5422      +993     
===========================================
+ Hits         1632     4444     +2812     
+ Misses       2797      978     -1819     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dimasciput dimasciput merged commit 3b91ae7 into qgis:master Dec 23, 2023
2 checks passed
@Xpirix Xpirix deleted the disable_matomo_cookies branch January 2, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants