Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/logout on profile button #339

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

TheGreatRefrigerator
Copy link
Contributor

This fixes an issue with clicking the profile button as non-admin user.
And some small additional problems (see commits)

previously clicking on the profile button would log the user out.
This now loads the "my plugins" page which is more intuitive as it before
needed the detour over the plugins page.
admin -> admin
staff -> staff
creator -> creator
Copy link
Collaborator

@Xpirix Xpirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @TheGreatRefrigerator

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9dabb5) 36.97% compared to head (9816967) 36.97%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files         106      106           
  Lines        4500     4500           
=======================================
  Hits         1664     1664           
  Misses       2836     2836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dimasciput dimasciput merged commit fe8b04d into qgis:master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants