Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show review form for style managers #355

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Feb 5, 2024

Currently, only staff users can review (approve or reject) a style.

Changes summary

This PR is a fix to show the style review form for staff users and users in the Group Style Managers.

image

Requirements

In the administration panel, the permissions for that Group should be updated (Chosen permissions are empty):

image

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a062b30) 36.08% compared to head (b075095) 36.06%.

Files Patch % Lines
qgis-app/base/views/processing_view.py 0.00% 1 Missing ⚠️
qgis-app/styles/tests/test_views.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   36.08%   36.06%   -0.02%     
==========================================
  Files         111      111              
  Lines        4897     4899       +2     
==========================================
  Hits         1767     1767              
- Misses       3130     3132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dimasciput dimasciput merged commit 998e0b5 into qgis:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants