Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smtp.gmail.com as EMAIL_HOST #356

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Feb 13, 2024

This PR is a fix for the email-sending feature since noreply@qgis.org goes sometimes in the spam folder.

Change summary:

  • Use smtp.gmail.com as email host
  • Replace noreply@qgis.org with automation@qgis.org

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.45%. Comparing base (32e0504) to head (5bfb1ca).

Files Patch % Lines
qgis-app/plugins/tests/test_plugin_update.py 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #356       +/-   ##
===========================================
+ Coverage   36.08%   82.45%   +46.37%     
===========================================
  Files         111      149       +38     
  Lines        4900     5933     +1033     
===========================================
+ Hits         1768     4892     +3124     
+ Misses       3132     1041     -2091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xpirix Xpirix changed the title Use gmail as email provider Use smtp.gmail.com as EMAIL_HOST Feb 19, 2024
@Xpirix Xpirix marked this pull request as draft February 19, 2024 05:38
@Xpirix Xpirix marked this pull request as ready for review February 26, 2024 08:46
@dimasciput dimasciput merged commit 173850f into qgis:master Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants