Commit
- Loading branch information
There are no files selected for viewing
3 comments
on commit 4e15534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volaya from what I've been told, The common step, unless it's an obvious and few characters fix, is to proceed through pull requests to inform other contributors and also avoid any typo or breakage of the doc build.
Then, afaict, a part of this commit is more about QGIS 3 changes and I am not sure we are currently documenting QGIS3 stuffs (still waiting for comments and decision in this thread). Moreover, I'm afraid your commit bypasses an ongoing discussion about how to treat such changes in next releases of documentation (namely, >=3.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, sorry. Do you want me to revert the commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes , please. However, would that be possible to open a PR for this? I think there are valuable texts that introduce the new changes we can keep for the 3.0 doc (+ some current fixes we could discuss)
Thanks @volaya
@volaya Better keep lines under 80 characters (it eases review and comment)