Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field calc - save and load expressions files #135

Closed
pigreco opened this issue Nov 28, 2018 · 10 comments
Closed

Field calc - save and load expressions files #135

pigreco opened this issue Nov 28, 2018 · 10 comments

Comments

@pigreco
Copy link
Sponsor

pigreco commented Nov 28, 2018

Field calc - save and load expressions files

Date 2018/11/28

Author Salvatore Fiandaca (@pigreco)

Contact pigrecoinfinito@gmail.com

maintainer @pigreco

Version QGIS 3.4

Summary

Add the buttons to save and import the most important expressions, to save time.
The recent group stores the first 20 expressions, but they always change.

Proposed Solution

(required)

image

(optional)

Affected Files

(required if applicable)

Performance Implications

(required if known at design time)

Further Considerations/Improvements

(optional)

Backwards Compatibility

(required)

Issue Tracking ID(s)

(optional)

Votes

(required)

@pigreco
Copy link
Sponsor Author

pigreco commented Nov 28, 2018

@Korto19
Copy link

Korto19 commented Nov 20, 2019

it would be really useful

@Jacopoog
Copy link

LOVELY Function Totò!!
Looking forward. It may be the first step to an "Automated field calc on several layers" new feature? I.E. a list/table with SavedFuncions to be applied to each Layer
By now, many many Thanks!!

@pigreco
Copy link
Sponsor Author

pigreco commented Nov 25, 2019

Here is a possible flow:

  1. I write expression,
  2. expression is valid;
  3. I can save my expression;
  4. by pressing on floppy, the dialog window opens; which displays the expression and define the name and description;
  5. list of saved expressions;
  6. possibility of eliminating expressions selected by the group, the icon appears only if an expression is selected.

image

@Korto19
Copy link

Korto19 commented Nov 25, 2019

Wonderful, this is what was missing. Very Very good Toto !

@elpaso
Copy link

elpaso commented Nov 25, 2019

I like the idea, I just would probably move the delete icon to the top to be consistent with the toolbar layout but that's a minor detail really.

Also we might consider adding a bulk import/export utility for stored expressions.

@jurajbetak
Copy link

Hello,
just some thoughts to design:

  • LOAD icon next to the SAVE icon (this might actually open the combo EXPRESSIONs SAVED)
  • What actually happens when you click the DELETE icon?) Instead, I would prefer to have Expression Manager (another icon next to SAVE) - with a separate window, where you can Delete, Edit, Create description notes, Import and Export (that would be nice if I can export my expressions e.g. to ZIP and import them elsewhere), ...

@elpaso
Copy link

elpaso commented Nov 28, 2019

Hello,
just some thoughts to design:

* LOAD icon next to the SAVE icon (this might actually open the combo EXPRESSIONs SAVED)

What for? The saved expressions appear in the expression tree under "Stored (generic)" (or whatever the context is).

* What actually happens when you click the DELETE icon?) 

The idea is that the delete icon will only appear when a stored expression is selected in the expression tree, the user will be asked for confirmation and the expression will be removed from the stored expressions. We might provide a context menu but in my experience that's the last resource in UX/UI design, it's much better and simpler to have a visible element to perform an action.

Instead, I would prefer to have Expression Manager (another icon next to SAVE) - with a separate window, where you can Delete, Edit, Create description notes, Import and Export (that would be nice if I can export my expressions e.g. to ZIP and import them elsewhere), ...

I agree, that would be also nice to have, but requires a bit more work, and it could be done later once the foundation API to store, retrieve and delete stored expressions is in place.

@pigreco
Copy link
Sponsor Author

pigreco commented Dec 14, 2019

@pigreco
Copy link
Sponsor Author

pigreco commented Jan 7, 2020

Done #33437 and #33462

@pigreco pigreco closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants