Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEP #7: Rename composer #9

Closed
wants to merge 8 commits into from

Conversation

nyalldawson
Copy link
Contributor

This proposal is regarding a change in terminology from "composition" -> "print layout".

- "Composer" -> "Layout Designer"
- "Composer Manager" -> "Layout Manager"

- For QGIS 3.0 and the next api break, rename internal classes and methods:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rename should occur now then. And use typedef and depcreated until v3.0.

@antoniolocandro
Copy link

Layout is a more common terminology in my opinion, so yes I think it should be done

@SrNetoChan
Copy link
Member

+1 for renaming "composer" to "layout". As stated before, "Layout" is a widelly used term both in GIS and design software.

Besides, if we have in consideration the meaning of the words, I believe that "layout" better suites what the tool does.

Composer
noun

  1. a person or thing that composes .
  2. a person who writes music.
  3. an author.

synonyms
writer

Layout
noun

  1. an arrangement or plan: We objected to the layout of the house.
  2. the act of laying or spreading out.
  3. a plan or sketch, as of an advertisement or a page of a newspaper or magazine, indicating the arrangement and relationship of the parts, as of type and artwork.
  4. (in advertising, publishing, etc.) the technique, process, or occupation of making layouts.
  5. spread .

synonyms
blueprint, design, draft, formation, map, organization, outline, plan, purpose

@3nids
Copy link
Member

3nids commented Oct 22, 2014

+1 too.

@NathanW2
Copy link
Member

+1
On Oct 22, 2014 7:11 PM, "Denis Rouzaud" notifications@github.com wrote:

+1 too.


Reply to this email directly or view it on GitHub
#9 (comment)
.

@nyalldawson
Copy link
Contributor Author

I've updated this QEP to remove most of the implementation details. Initially I'm just after approval to go ahead with this rename, and I'll post follow up QEPs about the implementation. Currently I'm leaning toward creating new classes as part of a clean up and refactor of composer, and deprecating the entire composition/composer framework. But that will be a separate discussion altogether...

@mewoch
Copy link

mewoch commented Nov 5, 2014

Just for a differing view, I quite like it being composer.

  • I'm the one doing the layout, so I'm composing the map - that works in my head.
  • It's pretty obvious what it is, even if it is not a "standard" term.
  • I don't think there is anything wrong with a bit of product differentiation, especially when this one is so much better than the "layout" tool in the other GIS product at my workplace. :)

@andreasneumann
Copy link
Member

+0.5 for layout. I don't have a very strong opinion about it. Layout seems obvious to me, but composer sounds also quite ok for me.

If the name "layout" helps for new users and for a future code redesign, I am fine with the new name.

@giohappy
Copy link

giohappy commented Nov 7, 2014

+1 for renaming it. Layout sounds more natural to many users (from informal polls during courses)

@NathanW2
Copy link
Member

NathanW2 commented Nov 9, 2014

@nyalldawson assigned number 7

@NathanW2 NathanW2 changed the title QEP - Rename composer QEP #7: Rename composer Nov 9, 2014
@nyalldawson
Copy link
Contributor Author

I've added some notes to clarify that this QEP relates solely to the user-visible rename of composer for 3.0, and does not touch any code implementation or api details. These will be submitted as follow up QEPs pending approval of a rename.

@NathanW2
Copy link
Member

So this is only for 3.0. If we do a 2.8 release this won't take effect
correct?

On Thu Nov 13 2014 at 7:33:39 AM Nyall Dawson notifications@github.com
wrote:

I've added some notes to clarify that this QEP relates solely to the
user-visible rename of composer for 3.0, and does not touch any code
implementation or api details. These will be submitted as follow up QEPs
pending approval of a rename.


Reply to this email directly or view it on GitHub
#9 (comment)
.

@nyalldawson
Copy link
Contributor Author

well, it will only apply to the rebuilt composer. Maybe the rebuild will be launched in parallel to the existing composer for 2.8, but that's a separate discussion. In any case, the existing composer functionality will still remain in 2.8 and still be named "composer".

@NathanW2
Copy link
Member

QEPs done via issues now.

New ticket at #43

Sorry for the inconvenience.

Email out soon on why.

@NathanW2 NathanW2 closed this Oct 28, 2015
@qgis qgis locked and limited conversation to collaborators Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants