Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping boxes in membership page #243

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented May 13, 2024

This is a proposed fix for #231

Please find below the screenshot of the change:

image

Summary by CodeRabbit

  • Style
    • Enhanced styling for the membership page to improve readability and aesthetic appeal.
  • New Features
    • Introduced additional padding in content sections for better visual separation.

Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

The recent updates involve enhancing the styling of specific content sections in a Markdown file by adding a new CSS class, and introducing a corresponding style rule in a SASS file. This change aims to improve the visual presentation of the content, making it more appealing and readable.

Changes

File Path Change Summary
.../funding/membership.md Added rich-content-text class to rich-content-start elements for improved styling.
.../hugo-bulma-blocks-theme/... Added .rich-content-text style rule with 20px padding.

🐰✨
A hop, a skip, a coding leap,
New styles weave as pages peep.
Padding here, a class anew,
Content sings in hues so true.
Cheers to changes, small and bright,
Crafting beauty in the light. 🌟
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (7)
content/funding/membership.md (7)

85-85: Ensure consistent heading levels.

The heading under "Public Acknowledgment" is marked as #### (h4), but the previous heading levels in the document are ### (h3). It's a good practice to maintain a consistent and sequential heading level to improve document structure and readability.


98-98: Ensure consistent heading levels.

The heading under "Enhanced Software Quality" is marked as #### (h4), but the previous heading levels in the document are ### (h3). It's a good practice to maintain a consistent and sequential heading level to improve document structure and readability.


108-108: Ensure consistent heading levels.

The heading under "Enhanced Brand Exposure" is marked as #### (h4), but the previous heading levels in the document are ### (h3). It's a good practice to maintain a consistent and sequential heading level to improve document structure and readability.


Line range hint 159-159: Clarify the section title.

The section title "How become a Sustaining Member" seems to be missing a verb. It should likely be "How to Become a Sustaining Member" to be grammatically correct.


Line range hint 251-251: Use appropriate prepositions.

The phrase "participating to our bug fixing initiative" should use "in" instead of "to". The correct phrase would be "participating in our bug fixing initiative".


Line range hint 259-259: Maintain consistency in terminology.

The document uses both "organisation" and "organization". It's important to maintain consistency in spelling, especially within the same document, to ensure professionalism and ease of reading. Choose one form and use it consistently.


Line range hint 259-259: Use a comma after introductory phrases.

After the phrase "For example" a comma is usually expected. The corrected phrase should be "For example, offers from marketing companies that have nothing to do with GIS / spatial services..."

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6cc9a16 and b547394.
Files selected for processing (2)
  • content/funding/membership.md (3 hunks)
  • themes/hugo-bulma-blocks-theme/assets/sass/style.sass (1 hunks)
Files skipped from review due to trivial changes (1)
  • themes/hugo-bulma-blocks-theme/assets/sass/style.sass
Additional Context Used
LanguageTool (20)
content/funding/membership.md (20)

Near line 17: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...Membership program QGIS is an entirely Open Source project. QGIS development is carried ou...


Near line 19: Nowadays, it’s more common to write this as one word.
Context: ...ode and binaries that we provide on our web site. As a result of this volunteer approach...


Near line 19: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...tion of information material, sometimes very expensive for volunteer developers. ## Sustaini...


Near line 68: A comma might be missing here.
Context: ... (unless they are simultaneously voting members in which case their voting rights are u...


Near line 159: Possible missing preposition found.
Context: ...the QGIS.ORG general assembly. ## How become a Sustaining Member {{< columns-star...


Near line 166: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 166: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} Reach out to the treasurer at finan...


Near line 179: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 179: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} The treasurer will gather necessary...


Near line 191: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 191: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} The treasurer verifies the receipt ...


Near line 203: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 203: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} Membership details are managed and ...


Near line 217: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 217: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} Recognition: Sustaining members...


Near line 233: Unpaired symbol: ‘"’ seems to be missing
Context: ... column-end >}} {{< column-start class="is-flex-direction-column is-align-items-...


Near line 233: Unpaired symbol: ‘"’ seems to be missing
Context: ...lign-items-flex-start is-three-quarters ">}} Past sustaining members are listed ...


Near line 251: The usual preposition for “participating” is “in”, not “to”.
Context: ...he project, e.g. hiring a developer, or participating to our bug fixing initiative. {{< rich-con...


Near line 259: Do not mix variants of the same word (‘organisation’ and ‘organization’) within a single text.
Context: ...of sustaining members if the membership organisation or party seems to be at odds with the e...


Near line 259: After the expression ‘for example’ a comma is usually used.
Context: ...odds with the ethos of our project. For example offers from marketing companies that ha...

@timlinux timlinux merged commit 3aadbe2 into qgis:main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants