[Geometry checker] If fixing an error produced changes, treat newly d…

…etected errors which are the same as the error fixed as actual new errors
qgis · Jul 14, 2016 · 2f6be7a · 2f6be7a
1 parent 41ce527
commit 2f6be7a
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/plugins/geometry_checker/qgsgeometrychecker.cpp b/src/plugins/geometry_checker/qgsgeometrychecker.cpp
@@ -155,14 +155,17 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError* error, int method )
     }
   }
 
-  // Remove just-fixed error from newly-found errors (needed in case error was fixed with "no change")
+  // Remove just-fixed error from newly-found errors if no changes occurred (needed in case error was fixed with "no change")
-  Q_FOREACH ( QgsGeometryCheckError* recheckErr, recheckErrors )
+  if ( changes.isEmpty() )
   {
-    if ( recheckErr->isEqual( error ) )
+    Q_FOREACH ( QgsGeometryCheckError* recheckErr, recheckErrors )
     {
-      recheckErrors.removeAll( recheckErr );
+      if ( recheckErr->isEqual( error ) )
-      delete recheckErr;
+      {
-      break;
+        recheckErrors.removeAll( recheckErr );
+        delete recheckErr;
+        break;
+      }
     }
   }