Skip to content
Permalink
Browse files

highlight fix

  • Loading branch information
blazek committed Jun 22, 2017
1 parent 5c6e794 commit 46596914e11dae13cd4d986941246c12f30aa0d9
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/gui/qgshighlight.cpp
@@ -257,7 +257,7 @@ void QgsHighlight::paintPolygon( QPainter *p, QgsPolygon polygon )

void QgsHighlight::updatePosition()
{
// nothing to do here...
QgsMapCanvasItem::updatePosition();
}

void QgsHighlight::paint( QPainter *p )

9 comments on commit 4659691

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied Jun 22, 2017

Good catch

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Jul 28, 2017

@blazek , this commit caused the following regression: https://issues.qgis.org/issues/16824

Is there any actual problem you were trying to fix here?

@3nids , ping, in case you know what this commit was trying to fix, and work on a regression-free alternative 😄

@blazek

This comment has been minimized.

Copy link
Member Author

@blazek blazek replied Jul 28, 2017

The fix resolved this problem:

  1. highlight a feature programmatically when it is outside current map canvas extent
  2. zoom to that feature
  3. the highlight disappears

Please don't simply revert without fixing the original problem.
More info http://lists.osgeo.org/pipermail/qgis-developer/2017-June/048948.html

(I'll be back on Monday)

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Aug 21, 2017

@blazek , gentle ping; is a solution being cooked for this regression?

@blazek

This comment has been minimized.

Copy link
Member Author

@blazek blazek replied Aug 22, 2017

Not just now but i keep it on mind.

@nyalldawson

This comment has been minimized.

Copy link
Collaborator

@nyalldawson nyalldawson replied Aug 22, 2017

I think we should revert for now - the original issue is less critical then the regression here (since its only evident when using PyQGIS, not day-to-day use). We can recommit when the regression is fixed.

@blazek

This comment has been minimized.

Copy link
Member Author

@blazek blazek replied Aug 23, 2017

OK, can you revert it? I dont have access to computer this week.

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Aug 25, 2017

@3nids , are you OK to revert this for the time being?

@blazek

This comment has been minimized.

Copy link
Member Author

@blazek blazek replied Aug 29, 2017

I have made another attempt to fix that in dbd86d0. It seems all to be working - zoom, pan, scale, rotate.

Please sign in to comment.
You can’t perform that action at this time.