Skip to content
Permalink
Browse files

Fix leak in point cloud 2d renderer

  • Loading branch information
nyalldawson committed Nov 6, 2020
1 parent 8cf5089 commit 4812f461e80de7c025e91ce29046ab7c540f52b6
Showing with 4 additions and 5 deletions.
  1. +2 −3 src/core/pointcloud/qgspointcloudrenderer.cpp
  2. +2 −2 src/core/pointcloud/qgspointcloudrenderer.h
@@ -81,10 +81,9 @@ QgsColorRamp *QgsPointCloudRendererConfig::colorRamp() const
return mColorRamp.get();
}

void QgsPointCloudRendererConfig::setColorRamp( const QgsColorRamp *value )
void QgsPointCloudRendererConfig::setColorRamp( QgsColorRamp *value )
{
// TODO should it clone?
mColorRamp.reset( value->clone() );
mColorRamp.reset( value );
}

float QgsPointCloudRendererConfig::maximumScreenError() const
@@ -68,8 +68,8 @@ class CORE_EXPORT QgsPointCloudRendererConfig
//! Returns color ramp
QgsColorRamp *colorRamp() const;

//! Sets color ramp
void setColorRamp( const QgsColorRamp *value );
//! Sets color ramp (ownership is transferrred)
void setColorRamp( QgsColorRamp *value SIP_TRANSFER );

//! Returns maximum allowed screen error in pixels
float maximumScreenError() const;

0 comments on commit 4812f46

Please sign in to comment.
You can’t perform that action at this time.