Fix leak in point cloud 2d renderer

qgis · Nov 6, 2020 · 4812f46 · 4812f46
1 parent 8cf5089
commit 4812f46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/core/pointcloud/qgspointcloudrenderer.cpp b/src/core/pointcloud/qgspointcloudrenderer.cpp
@@ -81,10 +81,9 @@ QgsColorRamp *QgsPointCloudRendererConfig::colorRamp() const
   return mColorRamp.get();
 }
 
-void QgsPointCloudRendererConfig::setColorRamp( const QgsColorRamp *value )
+void QgsPointCloudRendererConfig::setColorRamp( QgsColorRamp *value )
 {
-  // TODO should it clone?
-  mColorRamp.reset( value->clone() );
+  mColorRamp.reset( value );
 }
 
 float QgsPointCloudRendererConfig::maximumScreenError() const

diff --git a/src/core/pointcloud/qgspointcloudrenderer.h b/src/core/pointcloud/qgspointcloudrenderer.h
@@ -68,8 +68,8 @@ class CORE_EXPORT QgsPointCloudRendererConfig
     //! Returns color ramp
     QgsColorRamp *colorRamp() const;
 
-    //! Sets color ramp
-    void setColorRamp( const QgsColorRamp *value );
+    //! Sets color ramp (ownership is transferrred)
+    void setColorRamp( QgsColorRamp *value SIP_TRANSFER );
 
     //! Returns maximum allowed screen error in pixels
     float maximumScreenError() const;