Nicer way of ensuring selected character is in view

nyalldawson · nyalldawson · commit 57fa54763a83 · 2019-05-02T20:38:21.000+10:00
diff --git a/src/gui/symbology/characterwidget.cpp b/src/gui/symbology/characterwidget.cpp
@@ -118,7 +118,9 @@ void CharacterWidget::setCharacter( QChar character )
   {
     QScrollArea *scrollArea = qobject_cast< QScrollArea *>( widget->parent() );
     if ( scrollArea && mLastKey < 65536 )
-      scrollArea->verticalScrollBar()->setValue( mLastKey / mColumns * mSquareSize );
+    {
+      scrollArea->ensureVisible( 0, mLastKey / mColumns * mSquareSize );
+    }
   }
   if ( changed )
     emit characterSelected( mLastKey );

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,9 @@ void CharacterWidget::setCharacter( QChar character )`
`118`	`118`	`{`
`119`	`119`	`QScrollArea scrollArea = qobject_cast< QScrollArea >( widget->parent() );`
`120`	`120`	`if ( scrollArea && mLastKey < 65536 )`
`121`		`- scrollArea->verticalScrollBar()->setValue( mLastKey / mColumns * mSquareSize );`
	`121`	`+ {`
	`122`	`+ scrollArea->ensureVisible( 0, mLastKey / mColumns * mSquareSize );`
	`123`	`+ }`
`122`	`124`	`}`
`123`	`125`	`if ( changed )`
`124`	`126`	`emit characterSelected( mLastKey );`