Fix a bunch of memory leaks

...thanks Coverity, thoverity.

Author: nyalldawson

src/analysis/vector/qgstransectsample.cpp

@@ -595,6 +595,7 @@ QgsGeometry* QgsTransectSample::clipBufferLine( QgsGeometry* stratumGeom, QgsGeo
       bufferLine = QgsGeometry::fromMultiPolyline( mpl );
     }
     bufferLineClipped = bufferLine->intersection( stratumGeom );
+    delete bufferLine;
 
     if ( bufferLineClipped && bufferLineClipped->type() == QGis::Line )
     {
@@ -619,11 +620,13 @@ QgsGeometry* QgsTransectSample::clipBufferLine( QgsGeometry* stratumGeom, QgsGeo
 
       if ( bufferLineClippedIntersectsStratum )
       {
+        delete clipBaselineBuffer;
         return bufferLineClipped;
       }
     }
 
-    delete bufferLineClipped; delete clipBaselineBuffer; delete bufferLine;
+    delete bufferLineClipped;
+    delete clipBaselineBuffer;
     currentBufferDist /= 2;
   }
 

src/core/qgsgeometry.cpp

@@ -4661,7 +4661,9 @@ GEOSGeometry* QgsGeometry::linePointDifference( GEOSGeometry* GEOSsplitPoint )
   else
     return 0;
 
-  QgsPoint splitPoint = fromGeosGeom( GEOSsplitPoint )->asPoint();
+  QgsGeometry* geosPoint = fromGeosGeom( GEOSsplitPoint );
+  QgsPoint splitPoint = geosPoint->asPoint();
+  delete geosPoint;
 
   QgsMultiPolyline lines;
   QgsPolyline line;
@@ -4689,9 +4691,9 @@ GEOSGeometry* QgsGeometry::linePointDifference( GEOSGeometry* GEOSsplitPoint )
   }
   QgsGeometry* splitLines = fromMultiPolyline( lines );
   GEOSGeometry* splitGeom = GEOSGeom_clone_r( geosinit.ctxt, splitLines->asGeos() );
+  delete splitLines;
 
   return splitGeom;
-
 }
 
 int QgsGeometry::splitLinearGeometry( GEOSGeometry *splitLine, QList<QgsGeometry*>& newGeometries )

src/core/qgsgml.cpp

@@ -492,6 +492,7 @@ void QgsGml::endElement( const XML_Char* el )
     }
     else
     {
+      delete[] wkb;
       QgsDebugMsg( "no wkb fragments" );
     }
   }

src/core/qgsogcutils.cpp

@@ -1653,6 +1653,7 @@ QgsExpression::NodeFunction* QgsOgcUtils::nodeSpatialOperatorFromOgcFilter( QDom
   else
   {
     errorMessage = QString( "No OGC Geometry found" );
+    delete gml2Args;
     return NULL;
   }
 

src/core/raster/qgscubicrasterresampler.cpp

@@ -263,12 +263,15 @@ void QgsCubicRasterResampler::resample( const QImage& srcImage, QImage& dstImage
   delete[] redMatrix;
   delete[] greenMatrix;
   delete[] blueMatrix;
+  delete[] alphaMatrix;
   delete[] xDerivativeMatrixRed;
   delete[] xDerivativeMatrixGreen;
   delete[] xDerivativeMatrixBlue;
+  delete[] xDerivativeMatrixAlpha;
   delete[] yDerivativeMatrixRed;
   delete[] yDerivativeMatrixGreen;
   delete[] yDerivativeMatrixBlue;
+  delete[] yDerivativeMatrixAlpha;
 }
 
 void QgsCubicRasterResampler::xDerivativeMatrix( int nCols, int nRows, double* matrix, const int* colorMatrix )

src/core/raster/qgsrasterresamplefilter.cpp

@@ -167,6 +167,7 @@ QgsRasterBlock * QgsRasterResampleFilter::block( int bandNo, QgsRectangle  const
   if ((( oversampling < 1.0 || qgsDoubleNear( oversampling, 1.0 ) ) && !mZoomedInResampler ) || ( oversampling > 1.0 && !mZoomedOutResampler ) )
   {
     QgsDebugMsg( "No oversampling." );
+    delete outputBlock;
     return mInput->block( bandNumber, extent, width, height );
   }
 

src/core/symbology-ng/qgsfillsymbollayerv2.cpp

@@ -2974,6 +2974,7 @@ QgsPointPatternFillSymbolLayer::QgsPointPatternFillSymbolLayer(): QgsImageFillSy
 
 QgsPointPatternFillSymbolLayer::~QgsPointPatternFillSymbolLayer()
 {
+  delete mMarkerSymbol;
 }
 
 void QgsPointPatternFillSymbolLayer::setOutputUnit( QgsSymbolV2::OutputUnit unit )

src/core/symbology-ng/qgsvectorfieldsymbollayer.cpp

@@ -18,14 +18,24 @@
 #include "qgsvectorfieldsymbollayer.h"
 #include "qgsvectorlayer.h"
 
-QgsVectorFieldSymbolLayer::QgsVectorFieldSymbolLayer(): mXAttribute( "" ), mYAttribute( "" ), mDistanceUnit( QgsSymbolV2::MM ), mScale( 1.0 ),
-    mVectorFieldType( Cartesian ), mAngleOrientation( ClockwiseFromNorth ), mAngleUnits( Degrees ), mXIndex( -1 ), mYIndex( -1 )
+QgsVectorFieldSymbolLayer::QgsVectorFieldSymbolLayer()
+    : mXAttribute( "" )
+    , mYAttribute( "" )
+    , mDistanceUnit( QgsSymbolV2::MM )
+    , mScale( 1.0 )
+    , mVectorFieldType( Cartesian )
+    , mAngleOrientation( ClockwiseFromNorth )
+    , mAngleUnits( Degrees )
+    , mLineSymbol( 0 )
+    , mXIndex( -1 )
+    , mYIndex( -1 )
 {
   setSubSymbol( new QgsLineSymbolV2() );
 }
 
 QgsVectorFieldSymbolLayer::~QgsVectorFieldSymbolLayer()
 {
+  delete mLineSymbol;
 }
 
 void QgsVectorFieldSymbolLayer::setOutputUnit( QgsSymbolV2::OutputUnit unit )
@@ -124,6 +134,7 @@ bool QgsVectorFieldSymbolLayer::setSubSymbol( QgsSymbolV2* symbol )
 {
   if ( symbol->type() == QgsSymbolV2::Line )
   {
+    delete mLineSymbol;
     mLineSymbol = static_cast<QgsLineSymbolV2*>( symbol );
     return true;
   }

src/plugins/dxf2shp_converter/dxf2shpconvertergui.cpp

@@ -90,18 +90,19 @@ void dxf2shpConverterGui::on_buttonBox_accepted()
     convtexts );
 
   QgsDebugMsg( QString( "Finished getting insertions. Count: %1" ).arg( insertRetr->countInserts ) );
+  delete dxf_inserts;
 
   DL_Dxf *dxf_Main = new DL_Dxf();
 
   if ( !dxf_Main->in( inf.toStdString(), parser ) )
   {
     // if file open failed
+    delete dxf_Main;
     QgsDebugMsg( "Aborting: The input file could not be opened." );
     return;
   }
 
   delete insertRetr;
-  delete dxf_inserts;
   delete dxf_Main;
 
   parser->print_shpObjects();

src/plugins/roadgraph/shortestpathwidget.cpp

@@ -305,6 +305,7 @@ QgsGraph* RgShortestPathWidget::getPath( QgsPoint& p1, QgsPoint& p2 )
 
   if ( shortestpathTree->findVertex( p2 ) == -1 )
   {
+    delete shortestpathTree;
     QMessageBox::critical( this, tr( "Path not found" ), tr( "Path not found" ) );
     return NULL;
   }