Skip to content

Commit

Permalink
[processing] More string HIG fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Feb 21, 2018
1 parent bd99f69 commit 835cca7
Show file tree
Hide file tree
Showing 15 changed files with 29 additions and 29 deletions.
6 changes: 3 additions & 3 deletions python/plugins/processing/gui/BatchInputSelectionPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ def showPopupMenu(self):
if not (isinstance(self.param, QgsProcessingParameterMultipleLayers) and if not (isinstance(self.param, QgsProcessingParameterMultipleLayers) and
self.param.layerType == dataobjects.TYPE_FILE): self.param.layerType == dataobjects.TYPE_FILE):
selectLayerAction = QAction( selectLayerAction = QAction(
self.tr('Select from open layers'), self.pushButton) self.tr('Select from Open Layers…'), self.pushButton)
selectLayerAction.triggered.connect(self.showLayerSelectionDialog) selectLayerAction.triggered.connect(self.showLayerSelectionDialog)
popupmenu.addAction(selectLayerAction) popupmenu.addAction(selectLayerAction)


selectFileAction = QAction( selectFileAction = QAction(
self.tr('Select from file system'), self.pushButton) self.tr('Select from File System…'), self.pushButton)
selectFileAction.triggered.connect(self.showFileSelectionDialog) selectFileAction.triggered.connect(self.showFileSelectionDialog)
popupmenu.addAction(selectFileAction) popupmenu.addAction(selectFileAction)


Expand Down Expand Up @@ -156,7 +156,7 @@ def showFileSelectionDialog(self):
else: else:
path = '' path = ''


ret, selected_filter = QFileDialog.getOpenFileNames(self, self.tr('Open file'), path, ret, selected_filter = QFileDialog.getOpenFileNames(self, self.tr('Select Files'), path,
getFileFilter(self.param)) getFileFilter(self.param))
if ret: if ret:
files = list(ret) files = list(ret)
Expand Down
4 changes: 2 additions & 2 deletions python/plugins/processing/gui/BatchOutputSelectionPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def showSelectionDialog(self):
else: else:
path = '' path = ''
filename, selectedFileFilter = QFileDialog.getSaveFileName(self, filename, selectedFileFilter = QFileDialog.getSaveFileName(self,
self.tr('Save file'), path, filefilter) self.tr('Save File'), path, filefilter)
if filename: if filename:
if not filename.lower().endswith( if not filename.lower().endswith(
tuple(re.findall("\\*(\\.[a-z]{1,10})", filefilter))): tuple(re.findall("\\*(\\.[a-z]{1,10})", filefilter))):
Expand Down Expand Up @@ -143,7 +143,7 @@ def selectDirectory(self):
lastDir = '' lastDir = ''


dirName = QFileDialog.getExistingDirectory(self, dirName = QFileDialog.getExistingDirectory(self,
self.tr('Select directory'), lastDir, QFileDialog.ShowDirsOnly) self.tr('Output Directory'), lastDir, QFileDialog.ShowDirsOnly)


if dirName: if dirName:
self.table.cellWidget(self.row, self.col).setValue(dirName) self.table.cellWidget(self.row, self.col).setValue(dirName)
Expand Down
14 changes: 7 additions & 7 deletions python/plugins/processing/gui/DestinationSelectionPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -102,23 +102,23 @@ def selectOutput(self):


if self.parameter.flags() & QgsProcessingParameterDefinition.FlagOptional: if self.parameter.flags() & QgsProcessingParameterDefinition.FlagOptional:
actionSkipOutput = QAction( actionSkipOutput = QAction(
self.tr('Skip output'), self.btnSelect) self.tr('Skip Output'), self.btnSelect)
actionSkipOutput.triggered.connect(self.skipOutput) actionSkipOutput.triggered.connect(self.skipOutput)
popupMenu.addAction(actionSkipOutput) popupMenu.addAction(actionSkipOutput)


if isinstance(self.parameter, QgsProcessingParameterFeatureSink) \ if isinstance(self.parameter, QgsProcessingParameterFeatureSink) \
and self.parameter.supportsNonFileBasedOutput(): and self.parameter.supportsNonFileBasedOutput():
# use memory layers for temporary layers if supported # use memory layers for temporary layers if supported
actionSaveToTemp = QAction( actionSaveToTemp = QAction(
self.tr('Create temporary layer'), self.btnSelect) self.tr('Create Temporary Layer'), self.btnSelect)
else: else:
actionSaveToTemp = QAction( actionSaveToTemp = QAction(
self.tr('Save to a temporary file'), self.btnSelect) self.tr('Save to a Temporary File'), self.btnSelect)
actionSaveToTemp.triggered.connect(self.saveToTemporary) actionSaveToTemp.triggered.connect(self.saveToTemporary)
popupMenu.addAction(actionSaveToTemp) popupMenu.addAction(actionSaveToTemp)


actionSaveToFile = QAction( actionSaveToFile = QAction(
QCoreApplication.translate('DestinationSelectionPanel', 'Save to file…'), self.btnSelect) QCoreApplication.translate('DestinationSelectionPanel', 'Save to File…'), self.btnSelect)
actionSaveToFile.triggered.connect(self.selectFile) actionSaveToFile.triggered.connect(self.selectFile)
popupMenu.addAction(actionSaveToFile) popupMenu.addAction(actionSaveToFile)


Expand All @@ -129,7 +129,7 @@ def selectOutput(self):
actionSaveToGpkg.triggered.connect(self.saveToGeopackage) actionSaveToGpkg.triggered.connect(self.saveToGeopackage)
popupMenu.addAction(actionSaveToGpkg) popupMenu.addAction(actionSaveToGpkg)
actionSaveToPostGIS = QAction( actionSaveToPostGIS = QAction(
QCoreApplication.translate('DestinationSelectionPanel', 'Save to PostGIS table…'), self.btnSelect) QCoreApplication.translate('DestinationSelectionPanel', 'Save to PostGIS Table…'), self.btnSelect)
actionSaveToPostGIS.triggered.connect(self.saveToPostGIS) actionSaveToPostGIS.triggered.connect(self.saveToPostGIS)
settings = QgsSettings() settings = QgsSettings()
settings.beginGroup('/PostgreSQL/connections/') settings.beginGroup('/PostgreSQL/connections/')
Expand All @@ -139,7 +139,7 @@ def selectOutput(self):
popupMenu.addAction(actionSaveToPostGIS) popupMenu.addAction(actionSaveToPostGIS)


actionSetEncoding = QAction( actionSetEncoding = QAction(
QCoreApplication.translate('DestinationSelectionPanel', 'Change file encoding ({})…').format(self.encoding), self.btnSelect) QCoreApplication.translate('DestinationSelectionPanel', 'Change File Encoding ({})…').format(self.encoding), self.btnSelect)
actionSetEncoding.triggered.connect(self.selectEncoding) actionSetEncoding.triggered.connect(self.selectEncoding)
popupMenu.addAction(actionSetEncoding) popupMenu.addAction(actionSetEncoding)


Expand Down Expand Up @@ -260,7 +260,7 @@ def selectDirectory(self):
if not lastDir: if not lastDir:
lastDir = settings.value("/Processing/LastOutputPath", QDir.homePath()) lastDir = settings.value("/Processing/LastOutputPath", QDir.homePath())


dirName = QFileDialog.getExistingDirectory(self, self.tr('Select directory'), dirName = QFileDialog.getExistingDirectory(self, self.tr('Select Directory'),
lastDir, QFileDialog.ShowDirsOnly) lastDir, QFileDialog.ShowDirsOnly)
if dirName: if dirName:
self.leText.setText(QDir.toNativeSeparators(dirName)) self.leText.setText(QDir.toNativeSeparators(dirName))
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/ExtentSelectionPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def useLayerExtent(self):
layerName = layer.name() layerName = layer.name()
extents.append(layerName) extents.append(layerName)
extentsDict[layerName] = {"extent": layer.extent(), "authid": authid} extentsDict[layerName] = {"extent": layer.extent(), "authid": authid}
(item, ok) = QInputDialog.getItem(self, self.tr('Select extent'), (item, ok) = QInputDialog.getItem(self, self.tr('Select Extent'),
self.tr('Use extent from'), extents, False) self.tr('Use extent from'), extents, False)
if ok: if ok:
self.setValueFromRect(QgsReferencedRectangle(extentsDict[item]["extent"], QgsCoordinateReferenceSystem(extentsDict[item]["authid"]))) self.setValueFromRect(QgsReferencedRectangle(extentsDict[item]["extent"], QgsCoordinateReferenceSystem(extentsDict[item]["authid"])))
Expand Down
4 changes: 2 additions & 2 deletions python/plugins/processing/gui/FileSelectionPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ def showSelectionDialog(self):


if self.isFolder: if self.isFolder:
folder = QFileDialog.getExistingDirectory(self, folder = QFileDialog.getExistingDirectory(self,
self.tr('Select folder'), path) self.tr('Select Folder'), path)
if folder: if folder:
self.leText.setText(folder) self.leText.setText(folder)
settings.setValue('/Processing/LastInputPath', settings.setValue('/Processing/LastInputPath',
os.path.dirname(folder)) os.path.dirname(folder))
else: else:
filenames, selected_filter = QFileDialog.getOpenFileNames(self, filenames, selected_filter = QFileDialog.getOpenFileNames(self,
self.tr('Select file'), path, self.tr('{} files').format(self.ext.upper()) + ' (*.' + self.ext + self.tr(');;All files (*.*)')) self.tr('Select File'), path, self.tr('{} files').format(self.ext.upper()) + ' (*.' + self.ext + self.tr(');;All files (*.*)'))
if filenames: if filenames:
self.leText.setText(u';'.join(filenames)) self.leText.setText(u';'.join(filenames))
settings.setValue('/Processing/LastInputPath', settings.setValue('/Processing/LastInputPath',
Expand Down
4 changes: 2 additions & 2 deletions python/plugins/processing/gui/HistoryDialog.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def clearLog(self):


def saveLog(self): def saveLog(self):
fileName, filter = QFileDialog.getSaveFileName(self, fileName, filter = QFileDialog.getSaveFileName(self,
self.tr('Save file'), '.', self.tr('Log files (*.log *.LOG)')) self.tr('Save File'), '.', self.tr('Log files (*.log *.LOG)'))


if fileName == '': if fileName == '':
return return
Expand Down Expand Up @@ -133,7 +133,7 @@ def showPopupMenu(self, point):
if isinstance(item, TreeLogEntryItem): if isinstance(item, TreeLogEntryItem):
if item.isAlg: if item.isAlg:
popupmenu = QMenu() popupmenu = QMenu()
createTestAction = QAction(self.tr('Create test'), self.tree) createTestAction = QAction(self.tr('Create Test…'), self.tree)
createTestAction.triggered.connect(self.createTest) createTestAction.triggered.connect(self.createTest)
popupmenu.addAction(createTestAction) popupmenu.addAction(createTestAction)
popupmenu.exec_(self.tree.mapToGlobal(point)) popupmenu.exec_(self.tree.mapToGlobal(point))
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/MultipleFileInputDialog.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def addFile(self):
path = '' path = ''


files, selected_filter = QFileDialog.getOpenFileNames(self, files, selected_filter = QFileDialog.getOpenFileNames(self,
self.tr('Select file(s)'), path, self.tr('All files (*.*)')) self.tr('Select File(s)'), path, self.tr('All files (*.*)'))


if len(files) == 0: if len(files) == 0:
return return
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/MultipleInputDialog.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def addFiles(self):
settings = QgsSettings() settings = QgsSettings()
path = str(settings.value('/Processing/LastInputPath')) path = str(settings.value('/Processing/LastInputPath'))


ret, selected_filter = QFileDialog.getOpenFileNames(self, self.tr('Select file(s)'), ret, selected_filter = QFileDialog.getOpenFileNames(self, self.tr('Select File(s)'),
path, filter) path, filter)
if ret: if ret:
files = list(ret) files = list(ret)
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/NumberInputPanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def showExpressionsBuilder(self):


dlg = QgsExpressionBuilderDialog(None, str(self.leText.text()), self, 'generic', context) dlg = QgsExpressionBuilderDialog(None, str(self.leText.text()), self, 'generic', context)


dlg.setWindowTitle(self.tr('Expression based input')) dlg.setWindowTitle(self.tr('Expression Based Input'))
if dlg.exec_() == QDialog.Accepted: if dlg.exec_() == QDialog.Accepted:
exp = QgsExpression(dlg.expressionText()) exp = QgsExpression(dlg.expressionText())
if not exp.hasParserError(): if not exp.hasParserError():
Expand Down
6 changes: 3 additions & 3 deletions python/plugins/processing/gui/ProcessingToolbox.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -232,19 +232,19 @@ def showPopupMenu(self, point):
popupmenu = QMenu() popupmenu = QMenu()
if isinstance(item, TreeAlgorithmItem): if isinstance(item, TreeAlgorithmItem):
alg = item.alg alg = item.alg
executeAction = QAction(self.tr('Execute'), self.algorithmTree) executeAction = QAction(self.tr('Execute'), self.algorithmTree)
executeAction.triggered.connect(self.executeAlgorithm) executeAction.triggered.connect(self.executeAlgorithm)
popupmenu.addAction(executeAction) popupmenu.addAction(executeAction)
if alg.flags() & QgsProcessingAlgorithm.FlagSupportsBatch: if alg.flags() & QgsProcessingAlgorithm.FlagSupportsBatch:
executeBatchAction = QAction( executeBatchAction = QAction(
self.tr('Execute as batch process'), self.tr('Execute as Batch Process…'),
self.algorithmTree) self.algorithmTree)
executeBatchAction.triggered.connect( executeBatchAction.triggered.connect(
self.executeAlgorithmAsBatchProcess) self.executeAlgorithmAsBatchProcess)
popupmenu.addAction(executeBatchAction) popupmenu.addAction(executeBatchAction)
popupmenu.addSeparator() popupmenu.addSeparator()
editRenderingStylesAction = QAction( editRenderingStylesAction = QAction(
self.tr('Edit rendering styles for outputs'), self.tr('Edit Rendering Styles for Outputs…'),
self.algorithmTree) self.algorithmTree)
editRenderingStylesAction.triggered.connect( editRenderingStylesAction.triggered.connect(
self.editRenderingStyles) self.editRenderingStyles)
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/RenderingStyleFilePanel.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def __init__(self):


def showSelectionDialog(self): def showSelectionDialog(self):
filename, selected_filter = QFileDialog.getOpenFileName(self, filename, selected_filter = QFileDialog.getOpenFileName(self,
self.tr('Select style file'), '', self.tr('Select Style File'), '',
self.tr('QGIS Layer Style File (*.qml *.QML)')) self.tr('QGIS Layer Style File (*.qml *.QML)'))
if filename: if filename:
self.leText.setText(filename) self.leText.setText(filename)
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/gui/TestTools.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def __init__(self, s):
QDialog.__init__(self) QDialog.__init__(self)
self.setModal(True) self.setModal(True)
self.resize(600, 400) self.resize(600, 400)
self.setWindowTitle(self.tr('Unit test')) self.setWindowTitle(self.tr('Unit Test'))
layout = QVBoxLayout() layout = QVBoxLayout()
self.text = QTextEdit() self.text = QTextEdit()
self.text.setFontFamily("monospace") self.text.setFontFamily("monospace")
Expand Down
4 changes: 2 additions & 2 deletions python/plugins/processing/gui/wrappers.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def getFileName(self, initial_value=''):
path = '' path = ''


# TODO: should use selectedFilter argument for default file format # TODO: should use selectedFilter argument for default file format
filename, selected_filter = QFileDialog.getOpenFileName(self.widget, self.tr('Select file'), filename, selected_filter = QFileDialog.getOpenFileName(self.widget, self.tr('Select File'),
path, getFileFilter(self.param)) path, getFileFilter(self.param))
if filename: if filename:
settings.setValue('/Processing/LastInputPath', settings.setValue('/Processing/LastInputPath',
Expand Down Expand Up @@ -505,7 +505,7 @@ def selectFile(self):
filter = self.tr('All files (*.*)') filter = self.tr('All files (*.*)')


filename, selected_filter = QFileDialog.getOpenFileName(self.widget, filename, selected_filter = QFileDialog.getOpenFileName(self.widget,
self.tr('Select file'), path, self.tr('Select File'), path,
filter) filter)
if filename: if filename:
self.combo.setEditText(filename) self.combo.setEditText(filename)
Expand Down
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
class AddModelFromFileAction(ToolboxAction): class AddModelFromFileAction(ToolboxAction):


def __init__(self): def __init__(self):
self.name = self.tr('Add Model From File…') self.name = self.tr('Add Model from File…')
self.group = self.tr('Tools') self.group = self.tr('Tools')


def getIcon(self): def getIcon(self):
Expand Down
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
class AddScriptFromFileAction(ToolboxAction): class AddScriptFromFileAction(ToolboxAction):


def __init__(self): def __init__(self):
self.name = self.tr("Add Script From File…") self.name = self.tr("Add Script from File…")
self.group = self.tr("Tools") self.group = self.tr("Tools")


def execute(self): def execute(self):
Expand Down

0 comments on commit 835cca7

Please sign in to comment.