Skip to content

Commit 83eed11

Browse files
committed
Improve renderer class documentation (refs #14025)
1 parent b5ee06d commit 83eed11

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

python/core/symbology-ng/qgsrendererv2.sip

+17
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,17 @@ class QgsFeatureRendererV2
6262
QString type() const;
6363

6464
/** To be overridden
65+
*
66+
* Must be called between startRender() and stopRender() calls.
6567
* @param feature feature
6668
* @return returns pointer to symbol or 0 if symbol was not found
6769
* @deprecated use symbolForFeature( QgsFeature& feature, QgsRenderContext& context ) instead
6870
*/
6971
virtual QgsSymbolV2* symbolForFeature( QgsFeature& feature ) /Deprecated/;
7072

7173
/** To be overridden
74+
*
75+
* Must be called between startRender() and stopRender() calls.
7276
* @param feature feature
7377
* @param context render context
7478
* @return returns pointer to symbol or 0 if symbol was not found
@@ -109,6 +113,9 @@ class QgsFeatureRendererV2
109113
//! @deprecated since 2.4 - not using QgsVectorLayer directly anymore
110114
virtual void startRender( QgsRenderContext& context, const QgsVectorLayer *vlayer ) /Deprecated/;
111115

116+
/**
117+
* Needs to be called when a render cycle has finished to clean up.
118+
*/
112119
virtual void stopRender( QgsRenderContext& context ) = 0;
113120

114121
/**
@@ -130,6 +137,16 @@ class QgsFeatureRendererV2
130137

131138
virtual QgsFeatureRendererV2* clone() const = 0 /Factory/;
132139

140+
/**
141+
* Render a feature using this renderer in the given context.
142+
* Must be called between startRender() and stopRender() calls.
143+
* Default implementation renders a symbol as determined by symbolForFeature() call.
144+
* Returns true if the feature has been returned (this is used for example
145+
* to determine whether the feature may be labelled).
146+
*
147+
* If layer is not -1, the renderer should draw only a particula layer from symbols
148+
* (in order to support symbol level rendering).
149+
*/
133150
virtual bool renderFeature( QgsFeature& feature, QgsRenderContext& context, int layer = -1, bool selected = false, bool drawVertexMarker = false );
134151

135152
//! for debugging

src/core/symbology-ng/qgsrendererv2.h

+17
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,17 @@ class CORE_EXPORT QgsFeatureRendererV2
8383
QString type() const { return mType; }
8484

8585
/** To be overridden
86+
*
87+
* Must be called between startRender() and stopRender() calls.
8688
* @param feature feature
8789
* @return returns pointer to symbol or 0 if symbol was not found
8890
* @deprecated use symbolForFeature( QgsFeature& feature, QgsRenderContext& context ) instead
8991
*/
9092
Q_DECL_DEPRECATED virtual QgsSymbolV2* symbolForFeature( QgsFeature& feature );
9193

9294
/** To be overridden
95+
*
96+
* Must be called between startRender() and stopRender() calls.
9397
* @param feature feature
9498
* @param context render context
9599
* @return returns pointer to symbol or 0 if symbol was not found
@@ -137,6 +141,9 @@ class CORE_EXPORT QgsFeatureRendererV2
137141
//! @deprecated since 2.4 - not using QgsVectorLayer directly anymore
138142
Q_DECL_DEPRECATED virtual void startRender( QgsRenderContext& context, const QgsVectorLayer* vlayer );
139143

144+
/**
145+
* Needs to be called when a render cycle has finished to clean up.
146+
*/
140147
virtual void stopRender( QgsRenderContext& context ) = 0;
141148

142149
/**
@@ -163,6 +170,16 @@ class CORE_EXPORT QgsFeatureRendererV2
163170

164171
virtual QgsFeatureRendererV2* clone() const = 0;
165172

173+
/**
174+
* Render a feature using this renderer in the given context.
175+
* Must be called between startRender() and stopRender() calls.
176+
* Default implementation renders a symbol as determined by symbolForFeature() call.
177+
* Returns true if the feature has been returned (this is used for example
178+
* to determine whether the feature may be labelled).
179+
*
180+
* If layer is not -1, the renderer should draw only a particula layer from symbols
181+
* (in order to support symbol level rendering).
182+
*/
166183
virtual bool renderFeature( QgsFeature& feature, QgsRenderContext& context, int layer = -1, bool selected = false, bool drawVertexMarker = false );
167184

168185
//! for debugging

0 commit comments

Comments
 (0)