-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bfbe19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elpaso This replaces a previous commit from you (01b4eeb)
I assume you wanted to fix the crash and not assessing in detail why
layer->layer()
can be anullptr
and enforce that this never happens, right?This randomly crashes for me once in a while when reloading projects.
8bfbe19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn yes, I've ran into that bug while working on the new layers dialog, my first attempt was to add a check for
layer()
like you did (well, almost like you did: my check was on the uncastedlayer()
) , but after addingQt::QueuedConnection
I was not able to reproduce the issue anymore and I though that it was solved, apparently I was mistaken, thanks for fixing it.