Fix #11143 take 3 (cannot remove visibility groups)

Now we also handle rules that are not valid anymore
qgis · Sep 10, 2014 · 95f4a30 · 95f4a30
1 parent 4ef67ca
commit 95f4a30
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/app/qgsvisibilitygroups.cpp b/src/app/qgsvisibilitygroups.cpp
@@ -256,6 +256,30 @@ void QgsVisibilityGroups::applyState( const QString& groupName )
     return;
 
   applyStateToLayerTreeGroup( QgsProject::instance()->layerTreeRoot(), mGroups[groupName] );
+
+  // also make sure that the group is up-to-date (not containing any non-existant legend items)
+  if ( mGroups[groupName] == currentState() )
+    return; // no need for update
+
+  GroupRecord& rec = mGroups[groupName];
+  foreach ( QString layerID, rec.mPerLayerCheckedLegendSymbols.keys() )
+  {
+    QgsVectorLayer* vl = qobject_cast<QgsVectorLayer*>( QgsMapLayerRegistry::instance()->mapLayer( layerID ) );
+    if ( !vl || !vl->rendererV2() )
+      continue;
+
+    QSet<QString> validRuleKeys;
+    foreach ( const QgsLegendSymbolItemV2& item, vl->rendererV2()->legendSymbolItemsV2() )
+      validRuleKeys << item.ruleKey();
+
+    QSet<QString> invalidRuleKeys;
+    foreach ( QString ruleKey, rec.mPerLayerCheckedLegendSymbols[layerID] )
+      if ( !validRuleKeys.contains( ruleKey ) )
+        invalidRuleKeys << ruleKey;
+
+    foreach ( QString invalidRuleKey, invalidRuleKeys )
+      rec.mPerLayerCheckedLegendSymbols[layerID].remove( invalidRuleKey );
+  }
 }
 
 

diff --git a/src/app/qgsvisibilitygroups.h b/src/app/qgsvisibilitygroups.h
@@ -84,6 +84,10 @@ class QgsVisibilityGroups : public QObject
       {
         return mVisibleLayerIDs == other.mVisibleLayerIDs && mPerLayerCheckedLegendSymbols == other.mPerLayerCheckedLegendSymbols;
       }
+      bool operator!=( const GroupRecord& other ) const
+      {
+        return !( *this == other );
+      }
 
       //! List of layers that are visible
       QSet<QString> mVisibleLayerIDs;