[OAPIF provider] addFeatures(): use the id returned by the server to …

…fill the QGIS 'id' field, when it exists

Fixes #57486

src/providers/wfs/oapif/qgsoapifprovider.cpp

@@ -569,6 +569,7 @@ bool QgsOapifProvider::addFeatures( QgsFeatureList &flist, Flags flags )
     contentCrs = mShared->mSourceCrs.toOgcUri();
   }
   const bool hasAxisInverted = mShared->mSourceCrs.hasAxisInverted();
+  const int idFieldIdx = mShared->mFields.indexOf( "id" );
   for ( QgsFeature &f : flist )
   {
     QgsOapifCreateFeatureRequest req( uri );
@@ -579,6 +580,15 @@ bool QgsOapifProvider::addFeatures( QgsFeatureList &flist, Flags flags )
       return false;
     }
     jsonIds.append( id );
+
+    // If there's no feature["properties"]["id"] field in the JSON returned by the
+    // /items request, but there's a "id" field, it means that feature["id"]
+    // is non-numeric. Thus set the one returned by the createFeature() request
+    if ( !( flags & QgsFeatureSink::FastInsert ) &&
+         !mShared->mFoundIdInProperties && idFieldIdx >= 0 )
+    {
+      f.setAttribute( idFieldIdx, id );
+    }
   }
 
   QStringList::const_iterator idIt = jsonIds.constBegin();

tests/src/python/test_provider_oapif.py

@@ -1407,6 +1407,8 @@ def testFeatureInsertionDeletion(self):
         self.assertTrue(ret)
         self.assertEqual(fl[0].id(), 1)
         self.assertEqual(fl[1].id(), 2)
+        self.assertEqual(fl[0]["id"], "new_id")
+        self.assertEqual(fl[1]["id"], "other_id")
 
         # Failed attempt
         self.assertFalse(vl.dataProvider().deleteFeatures([1]))