-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
… from 1.8 use different keys for scanItemsInBrowser and scanZipInBrowser in qgis-1.9 because new storage type (string vs. int) causes conflicts with 1.8
- Loading branch information
There are no files selected for viewing
5 comments
on commit b754f07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Etienne,
since we have broken APIs and the next release will be QGis 2.0, IMHO it isn't worth to convert the 1.8 settings values to 1.9/2.0 ones if they need a so twisted conversion (it's some code we will need to maintain).
I'd just replace scanZipInBrowser with scanZipInBrowser2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I justs didn't want things to break for current users, but uf you think it's not worth it I can remove that and fix the default above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I justs didn't want things to break for current users, but uf you think it's not worth it I can remove that
It would be worth for critical tasks that makes master unusable, but IMO a such minor break could occur in the development version, especially if the next release will be 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks for your input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
0
the correct default value for scanItemsInBrowser2?