Fix logic in QgsUserInputWidget which incorrectly deletes other widge…

…ts whenever one existing widget is deleted
qgis · Oct 28, 2020 · c1adeb0 · c1adeb0
1 parent 497e313
commit c1adeb0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/gui/qgsuserinputwidget.cpp b/src/gui/qgsuserinputwidget.cpp
@@ -75,14 +75,14 @@ void QgsUserInputWidget::widgetDestroyed( QObject *obj )
   if ( obj->isWidgetType() )
   {
     QWidget *w = qobject_cast<QWidget *>( obj );
-    QMap<QWidget *, QFrame *>::iterator i = mWidgetList.find( w );
-    while ( i != mWidgetList.end() )
+    auto it = mWidgetList.find( w );
+    if ( it != mWidgetList.end() )
     {
-      if ( auto *lValue = i.value() )
+      if ( QFrame *frame = it.value() )
       {
-        lValue->deleteLater();
+        frame->deleteLater();
       }
-      i = mWidgetList.erase( i );
+      mWidgetList.erase( it );
     }
   }
   if ( mWidgetList.count() == 0 )