Fix leak in labeling due to expression context scope not being cleaned

correctly (master only)
qgis · Aug 12, 2019 · c567974 · c567974
1 parent 674d037
commit c567974
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/core/qgslabelingengine.cpp b/src/core/qgslabelingengine.cpp
@@ -339,7 +339,7 @@ void QgsLabelingEngine::run( QgsRenderContext &context )
   }
 
   QgsExpressionContextScope *symbolScope = new QgsExpressionContextScope();
-  context.expressionContext().appendScope( symbolScope );
+  std::unique_ptr< QgsExpressionContextScopePopper > symbolScopePopper = qgis::make_unique< QgsExpressionContextScopePopper >( context.expressionContext(), symbolScope );
 
   // draw label backgrounds
   for ( pal::LabelPosition *label : qgis::as_const( labels ) )
@@ -410,7 +410,7 @@ void QgsLabelingEngine::run( QgsRenderContext &context )
     }
   }
 
-  context.expressionContext().popScope();
+  symbolScopePopper.reset();
 
   // cleanup
   for ( QgsAbstractLabelProvider *provider : qgis::as_const( mProviders ) )