Skip to content

Commit cd353db

Browse files
committed
Log WFS errors
1 parent 1e2e481 commit cd353db

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/core/qgsgml.cpp

+10-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include "qgscoordinatereferencesystem.h"
1818
#include "qgsgeometry.h"
1919
#include "qgslogger.h"
20+
#include "qgsmessagelog.h"
2021
#include "qgsnetworkaccessmanager.h"
2122
#include <QBuffer>
2223
#include <QList>
@@ -104,7 +105,15 @@ int QgsGml::getFeatures( const QString& uri, QGis::WkbType* wkbType, QgsRectangl
104105
QByteArray readData = reply->readAll();
105106
if ( readData.size() > 0 )
106107
{
107-
XML_Parse( p, readData.constData(), readData.size(), atEnd );
108+
if ( XML_Parse( p, readData.constData(), readData.size(), atEnd ) == 0 )
109+
{
110+
XML_Error errorCode = XML_GetErrorCode( p );
111+
QString errorString = tr( "Error: %1 on line %2, column %3" )
112+
.arg( XML_ErrorString( errorCode ) )
113+
.arg( XML_GetCurrentLineNumber( p ) )
114+
.arg( XML_GetCurrentColumnNumber( p ) );
115+
QgsMessageLog::instance()->logMessage( errorString, tr( "WFS" ) );
116+
}
108117
}
109118
QCoreApplication::processEvents();
110119
}

src/providers/wfs/qgswfsprovider.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include "qgswfsprovider.h"
3030
#include "qgsspatialindex.h"
3131
#include "qgslogger.h"
32+
#include "qgsmessagelog.h"
3233
#include "qgsnetworkaccessmanager.h"
3334
#include "qgsogcutils.h"
3435

@@ -93,9 +94,7 @@ QgsWFSProvider::QgsWFSProvider( const QString& uri )
9394
if ( describeFeatureType( uri, mGeometryAttribute, mFields, mWKBType ) )
9495
{
9596
mValid = false;
96-
QgsDebugMsg( QString( "describeFeatureType failed, URI=%1" ).arg( uri ) );
97-
QMessageBox( QMessageBox::Warning, "DescribeFeatureType failed!",
98-
QString( "Layer cannot be created from\n%1" ).arg( uri ) );
97+
QgsMessageLog::instance()->logMessage( tr( "DescribeFeatureType failed for url %1" ).arg( uri ), tr( "WFS" ) );
9998
return;
10099
}
101100

0 commit comments

Comments
 (0)