Skip to content

Commit e355a60

Browse files
committed
Get rid of svn version stuff from release branch.
1 parent 92df029 commit e355a60

File tree

4 files changed

+30
-54
lines changed

4 files changed

+30
-54
lines changed

CMakeLists.txt

+25-46
Original file line numberDiff line numberDiff line change
@@ -439,64 +439,43 @@ INCLUDE_DIRECTORIES(${CMAKE_BINARY_DIR})
439439
LINK_DIRECTORIES(${CMAKE_BINARY_DIR}/src/core ${CMAKE_BINARY_DIR}/src/gui)
440440

441441
#############################################################
442-
# create qgssvnversion.h
442+
# create qgsversion.h
443443

444-
FIND_FILE(SVN_MARKER entries PATHS ${CMAKE_SOURCE_DIR}/.svn)
445-
FIND_FILE(GIT_MARKER index PATHS ${CMAKE_SOURCE_DIR}/.git)
446444

447-
IF (SVN_MARKER)
448-
# See if we have svn installed
449-
FIND_PROGRAM(SVNVERSION svnversion PATHS c:/cygwin/bin)
445+
FIND_FILE(GIT_MARKER index PATHS ${CMAKE_SOURCE_DIR}/.git)
450446

451-
IF(SVNVERSION)
447+
IF (GIT_MARKER)
448+
FIND_PROGRAM(GIT git PATHS c:/cygwin/bin)
449+
IF(GIT)
452450
IF(MSVC)
453451
ADD_CUSTOM_COMMAND(
454-
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
455-
COMMAND for /f usebackq %%a in "(`\"${SVNVERSION}\"`)" do echo \#define QGSSVNVERSION \"%%a\" >${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
456-
MAIN_DEPENDENCY ${SVN_MARKER}
452+
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h
453+
COMMAND for /f \"usebackq tokens=1\" %%a in "(`\"${GIT}\" log -n1 --oneline`)" do echo \#define QGSVERSION \"%%a\" >${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h
454+
MAIN_DEPENDENCY ${GIT_MARKER}
457455
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
458456
)
459457
ELSE(MSVC)
458+
MESSAGE(STATUS "writing ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h")
459+
EXECUTE_PROCESS(COMMAND ${GIT} log -n1 --pretty=%h OUTPUT_VARIABLE REVISION)
460+
STRING(STRIP "${REVISION}" REVISION)
460461
ADD_CUSTOM_COMMAND(
461-
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
462-
COMMAND echo \\\#define QGSSVNVERSION \\\"`${SVNVERSION}`\\\" >${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
463-
MAIN_DEPENDENCY ${SVN_MARKER}
462+
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h
463+
COMMAND echo \\\#define QGSVERSION \\\"${REVISION}\\\" >${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h
464+
MAIN_DEPENDENCY ${GIT_MARKER}
464465
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
465466
)
466467
ENDIF(MSVC)
467-
ELSE(SVNVERSION)
468-
MESSAGE(STATUS "svnversion not found - version will be unknown")
469-
FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h "#define QGSSVNVERSION \"unknown\"")
470-
ENDIF (SVNVERSION)
471-
ELSE (SVN_MARKER)
472-
IF (GIT_MARKER)
473-
FIND_PROGRAM(GIT git PATHS c:/cygwin/bin)
474-
IF(GIT)
475-
IF(MSVC)
476-
ADD_CUSTOM_COMMAND(
477-
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
478-
COMMAND for /f \"usebackq tokens=1\" %%a in "(`\"${GIT}\" log -n1 --oneline`)" do echo \#define QGSSVNVERSION \"%%a\" >${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
479-
MAIN_DEPENDENCY ${GIT_MARKER}
480-
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
481-
)
482-
ELSE(MSVC)
483-
ADD_CUSTOM_COMMAND(
484-
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
485-
COMMAND echo \\#define QGSSVNVERSION \\\"$$\( ${GIT} log -n1 --pretty=%h \)\\\" >${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h
486-
MAIN_DEPENDENCY ${GIT_MARKER}
487-
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
488-
)
489-
ENDIF(MSVC)
490-
ELSE(GIT)
491-
MESSAGE(STATUS "git marker, but no git found - version will be unknown")
492-
FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h "#define QGSSVNVERSION \"unknown\"")
493-
ENDIF(GIT)
494-
ELSE (GIT_MARKER)
495-
FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h "#define QGSSVNVERSION \"exported\"")
496-
ENDIF (GIT_MARKER)
497-
ENDIF (SVN_MARKER)
498-
499-
ADD_CUSTOM_TARGET(svnversion ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/qgssvnversion.h)
468+
ELSE(GIT)
469+
MESSAGE(STATUS "git marker, but no git found - version will be unknown")
470+
SET(REVISION "unknown")
471+
FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h "#define QGSVERSION \"unknown\"")
472+
ENDIF(GIT)
473+
ELSE (GIT_MARKER)
474+
SET(REVISION "exported")
475+
FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h "#define QGSVERSION \"exported\"")
476+
ENDIF (GIT_MARKER)
477+
478+
ADD_CUSTOM_TARGET(version ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/qgsversion.h)
500479

501480
#############################################################
502481
# process subdirs

src/app/main.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ typedef SInt32 SRefCon;
6767
#include "qgsmapcanvas.h"
6868
#include "qgsapplication.h"
6969
#include <qgsconfig.h>
70-
#include <qgssvnversion.h>
70+
#include <qgsversion.h>
7171
#include "qgsexception.h"
7272
#include "qgsproject.h"
7373
#include "qgsrectangle.h"
@@ -86,7 +86,7 @@ static const char * const ident_ = "$Id$";
8686
void usage( std::string const & appName )
8787
{
8888
std::cerr << "Quantum GIS - " << VERSION << " '" << RELEASE_NAME << "' ("
89-
<< QGSSVNVERSION << ")\n"
89+
<< QGis::QGIS_DEV_VERSION << ")\n"
9090
<< "Quantum GIS (QGIS) is a viewer for spatial data sets, including\n"
9191
<< "raster and vector data.\n"
9292
<< "Usage: " << appName << " [options] [FILES]\n"

src/app/qgisapp.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1916,7 +1916,7 @@ void QgisApp::about()
19161916
abt = new QgsAbout();
19171917
QString versionString = tr( "You are using QGIS version %1 built against code revision %2." )
19181918
.arg( QGis::QGIS_VERSION )
1919-
.arg( QGis::QGIS_SVN_VERSION );
1919+
.arg( QGis::QGIS_DEV_VERSION );
19201920

19211921
versionString += tr( "\nGDAL/OGR Version: %1." ).arg( GDAL_RELEASE_NAME );
19221922

src/core/qgis.cpp

+2-5
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
* *
1717
***************************************************************************/
1818
#include "qgis.h"
19-
#ifndef QGSSVNVERSION
20-
#include "qgssvnversion.h"
19+
#ifndef QGSVERSION
20+
#include "qgsversion.h"
2121
#endif
2222

2323
#include "qgsconfig.h"
@@ -28,9 +28,6 @@
2828
// Version string
2929
const char* QGis::QGIS_VERSION = VERSION;
3030

31-
// SVN version
32-
const char* QGis::QGIS_SVN_VERSION = QGSSVNVERSION;
33-
3431
// Version number used for comparing versions using the
3532
// "Check QGIS Version" function
3633
const int QGis::QGIS_VERSION_INT = VERSION_INT;

0 commit comments

Comments
 (0)