Use enum instead of raw int

qgis · May 15, 2024 · e7b8dc4 · e7b8dc4
1 parent 1c23950
commit e7b8dc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/gui/codeeditors/qgscodeeditorwidget.cpp b/src/gui/codeeditors/qgscodeeditorwidget.cpp
@@ -27,8 +27,6 @@
 #include <QShortcut>
 #include <QGridLayout>
 
-constexpr int WARNING_HIGHLIGHT_CATEGORY = 48;
-
 QgsCodeEditorWidget::QgsCodeEditorWidget(
   QgsCodeEditor *editor,
   QgsMessageBar *messageBar,
@@ -262,7 +260,7 @@ void QgsCodeEditorWidget::addWarning( int lineNumber, const QString &warning )
 
   mHighlightController->addHighlight(
     QgsScrollBarHighlight(
-      WARNING_HIGHLIGHT_CATEGORY,
+      HighlightCategory::Warning,
       lineNumber,
       QColor( 255, 0, 0 ),
       QgsScrollBarHighlight::Priority::HighestPriority
@@ -275,7 +273,7 @@ void QgsCodeEditorWidget::clearWarnings()
   mEditor->clearWarnings();
 
   mHighlightController->removeHighlights(
-    WARNING_HIGHLIGHT_CATEGORY
+    HighlightCategory::Warning
   );
 }
 

diff --git a/src/gui/codeeditors/qgscodeeditorwidget.h b/src/gui/codeeditors/qgscodeeditorwidget.h
@@ -176,7 +176,8 @@ class GUI_EXPORT QgsCodeEditorWidget : public QgsPanelWidget
 
     enum HighlightCategory
     {
-      SearchMatch = 0
+      SearchMatch = 0,
+      Warning = 1
     };
 
     QgsCodeEditor *mEditor = nullptr;