Skip to content
Permalink
Browse files

[processing] Fix capitalization, ellipsis in extent parameter widget

  • Loading branch information
nyalldawson committed Sep 21, 2018
1 parent 68dc698 commit f44be44ca9cd07ec99ccaa6ff63824df9d3848ea
Showing with 4 additions and 4 deletions.
  1. +4 −4 python/plugins/processing/gui/ExtentSelectionPanel.py
@@ -97,9 +97,9 @@ def __init__(self, dialog, param):
def selectExtent(self):
popupmenu = QMenu()
useLayerExtentAction = QAction(
self.tr('Use layer/canvas extent'), self.btnSelect)
self.tr('Use Layer/Canvas Extent…'), self.btnSelect)
selectOnCanvasAction = QAction(
self.tr('Select extent on canvas'), self.btnSelect)
self.tr('Select Extent on Canvas'), self.btnSelect)

popupmenu.addAction(useLayerExtentAction)
popupmenu.addAction(selectOnCanvasAction)
@@ -109,7 +109,7 @@ def selectExtent(self):

if self.param.flags() & QgsProcessingParameterDefinition.FlagOptional:
useMincoveringExtentAction = QAction(
self.tr('Use min covering extent from input layers'),
self.tr('Use Min Covering Extent from Input Layers'),

This comment has been minimized.

Copy link
@nirvn

nirvn Sep 21, 2018

Contributor

@nyalldawson , any reason why we use "Min" instead of "Minimum" here? I don' think we're constrained in space here, we might as well use the full word.

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson Sep 21, 2018

Author Collaborator

It could be reworded even better I think: "Extent of all Input Layers"?

This comment has been minimized.

Copy link
@nirvn

nirvn Sep 21, 2018

Contributor

Combined Extent of all Input Layers? As long as Min goes away, I'm happy 😉

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson Sep 21, 2018

Author Collaborator

go for it :D

self.btnSelect)
useMincoveringExtentAction.triggered.connect(
self.useMinCoveringExtent)
@@ -121,7 +121,7 @@ def useMinCoveringExtent(self):
self.leText.setText('')

def useLayerExtent(self):
CANVAS_KEY = 'Use canvas extent'
CANVAS_KEY = 'Canvas Extent'
extentsDict = {}
extentsDict[CANVAS_KEY] = {"extent": iface.mapCanvas().extent(),
"authid": iface.mapCanvas().mapSettings().destinationCrs().authid()}

0 comments on commit f44be44

Please sign in to comment.
You can’t perform that action at this time.